-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eclipsesource-minimal-json to maven dependencies #423
Merged
flyingsilverfin
merged 1 commit into
typedb:master
from
krishnangovindraj:add-json-dependency
Jun 7, 2023
Merged
Add eclipsesource-minimal-json to maven dependencies #423
flyingsilverfin
merged 1 commit into
typedb:master
from
krishnangovindraj:add-json-dependency
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnangovindraj
requested review from
alexjpwalker and
haikalpribadi
as code owners
June 7, 2023 14:03
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
flyingsilverfin
approved these changes
Jun 7, 2023
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-driver
that referenced
this pull request
Aug 9, 2023
## What is the goal of this PR? Adds `com.eclipsesource.minimal-json:minimal-json` to maven artifacts to reflect explicit dependency. ## What are the changes implemented in this PR? * Adds `com.eclipsesource.minimal-json:minimal-json` to maven artifacts to reflect explicit dependency. * updates.sh generates an unchanged `artifacts.snapshot` (since the dependency was transitively inherited anyway)
dmitrii-ubskii
added a commit
that referenced
this pull request
Aug 22, 2023
## What is the goal of this PR? We update the Rust driver to support the features introduced in driver Java since v2.19 in effort to preserve the feature set when transitioning from the JVM-native implementation to the Rust JNI implementation. ## What are the changes implemented in this PR? Changes in master since branching (#417): Reimplemented in Rust and made available in Java over JNI: - #409 - #421 - 1f396a6 Improve method unavailable error message - #430 - #431: partial, since `tonic` does not report SSL errors to the same granularity Cherry-picked directly: - #415 - 42800e7 Update VERSION to 2.18.1 - 7cd0a5a Add eclipsesource-minimal-json to maven dependencies (#423) - 63614ec Update CODEOWNERS - #424 Dropped entirely (Java-specific or obsolete): - #422 - 8c0caa1 Update VERSION and release notes --------- Co-authored-by: Benjamin Small <benjaminasmall@gmail.com> Co-authored-by: joshua <joshua@vaticle.com> Co-authored-by: Krishnan Govindraj <krishnangovindraj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Adds
com.eclipsesource.minimal-json:minimal-json
to maven artifacts to reflect explicit dependency.What are the changes implemented in this PR?
com.eclipsesource.minimal-json:minimal-json
to maven artifacts to reflect explicit dependency.artifacts.snapshot
(since the dependency was transitively inherited anyway)