Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eclipsesource-minimal-json to maven dependencies #423

Merged

Conversation

krishnangovindraj
Copy link
Member

What is the goal of this PR?

Adds com.eclipsesource.minimal-json:minimal-json to maven artifacts to reflect explicit dependency.

What are the changes implemented in this PR?

  • Adds com.eclipsesource.minimal-json:minimal-json to maven artifacts to reflect explicit dependency.
  • updates.sh generates an unchanged artifacts.snapshot (since the dependency was transitively inherited anyway)

@typedb-bot
Copy link
Member

typedb-bot commented Jun 7, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin merged commit 7cd0a5a into typedb:master Jun 7, 2023
dmitrii-ubskii pushed a commit to dmitrii-ubskii/typedb-driver that referenced this pull request Aug 9, 2023
## What is the goal of this PR?
Adds `com.eclipsesource.minimal-json:minimal-json` to maven artifacts to reflect explicit dependency.

## What are the changes implemented in this PR?
* Adds `com.eclipsesource.minimal-json:minimal-json` to maven artifacts to reflect explicit dependency.
* updates.sh generates an unchanged `artifacts.snapshot` (since the dependency was transitively inherited anyway)
dmitrii-ubskii added a commit that referenced this pull request Aug 22, 2023
## What is the goal of this PR?

We update the Rust driver to support the features introduced in driver
Java since v2.19 in effort to preserve the feature set when
transitioning from the JVM-native implementation to the Rust JNI
implementation.

## What are the changes implemented in this PR?

Changes in master since branching (#417):

Reimplemented in Rust and made available in Java over JNI:
- #409 
- #421 
- 1f396a6 Improve method unavailable error message
- #430 
- #431: partial, since `tonic` does not report SSL errors to the same
granularity

Cherry-picked directly:
- #415
- 42800e7 Update VERSION to 2.18.1
- 7cd0a5a Add eclipsesource-minimal-json to maven dependencies (#423)
- 63614ec Update CODEOWNERS
- #424

Dropped entirely (Java-specific or obsolete):
- #422 
- 8c0caa1 Update VERSION and release notes

---------

Co-authored-by: Benjamin Small <benjaminasmall@gmail.com>
Co-authored-by: joshua <joshua@vaticle.com>
Co-authored-by: Krishnan Govindraj <krishnangovindraj@users.noreply.github.com>
@krishnangovindraj krishnangovindraj deleted the add-json-dependency branch October 13, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants