Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift+End selects to end of file, not end of line #555

Closed
mathieuisabel opened this issue Jun 3, 2022 · 3 comments · Fixed by #655
Closed

Shift+End selects to end of file, not end of line #555

mathieuisabel opened this issue Jun 3, 2022 · 3 comments · Fixed by #655
Assignees
@jamesreprise
Labels
domain: text-editor priority: medium status: solved type: bug
Milestone
TypeDB Studio: 2....

Comments

@mathieuisabel
Copy link

Description

When doing Shift+End in a tab with multiple lines of queries/text, it will select up until the end of the file instead of up until the end of the line.

Same is true when doing the opposite with Shift+Home.

This doesn't match the standard behavior seen in most/all text editors.

I'm wondering if that's a WIndows only thing.

Environment

  1. TypeDB version: 2.10
  2. OS of TypeDB server: Windows 11
  3. Studio version: 2.10-alpha-4
  4. OS of Studio: Windows 11
  5. Other environment details:

Reproducible Steps

Steps to create the smallest reproducible scenario:

  • Enter two lines of text in the editor
  • Place your cursor at the beginning of the first line
  • Hit Shift-End

Expected Output

Select text up until the end of the current line.

Actual Output

All text is selected.

Additional information
@alexjpwalker alexjpwalker changed the title Text Selection with Keyboard Issue Shift+End selects to end of file, not end of line Jun 6, 2022
@alexjpwalker alexjpwalker self-assigned this Jun 6, 2022
@mathieuisabel
Copy link
Author

Just to be clear, this not only Shift+End but Shift+Home as well.

@mathieuisabel
Copy link
Author

Any chance this would get in the next release?

@alexjpwalker
Copy link
Member

I agree, this seems like something we should fix in the near future.

@jamesreprise jamesreprise mentioned this issue Nov 15, 2022
Merged
jamesreprise pushed a commit that referenced this issue Nov 15, 2022
Shift+Home/End selects to end of line (#655)
a6c2860 
## What is the goal of this PR?

Matching the way navigating with the Home & End keys works, adding the
shift key should only select to the end of the line rather than the end
of the file.

## What are the changes implemented in this PR?

SELECT_HOME and SELECT_END only select to the start of the line and the
end of the line rather than the start of the file and the end of the
file respectively.

Also refactored the names of functions that move the cursor to the start
or end of the file to make that fact explicit rather than implicit.

## Additional info

Closes #555
@alexjpwalker alexjpwalker mentioned this issue Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesreprise jamesreprise

Labels
domain: text-editor priority: medium status: solved type: bug
Projects
None yet
Milestone
TypeDB Studio: 2.14 Completion
Development

Successfully merging a pull request may close this issue.

Shift+Home/End selects to end of line jamesreprise/typedb-studio
4 participants
@alexjpwalker @mathieuisabel @jamesreprise @typedb-bot