Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Home/End selects to end of line #655

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

jamesreprise
Copy link
Contributor

What is the goal of this PR?

Matching the way navigating with the Home & End keys works, adding the shift key should only select to the end of the line rather than the end of the file.

What are the changes implemented in this PR?

SELECT_HOME and SELECT_END only select to the start of the line and the end of the line rather than the start of the file and the end of the file respectively.

Also refactored the names of functions that move the cursor to the start or end of the file to make that fact explicit rather than implicit.

Additional info

Closes #555

@typedb-bot
Copy link
Member

typedb-bot commented Nov 15, 2022

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@jamesreprise jamesreprise changed the title Shift+Home/End select to end of line Shift+Home/End selects to end of line Nov 15, 2022
@jamesreprise jamesreprise merged commit a6c2860 into typedb:development Nov 15, 2022
@jamesreprise jamesreprise deleted the home-end-select branch November 18, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift+End selects to end of file, not end of line
3 participants