Improve some DB expression types #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
reviewed
Nov 9, 2022
|
Sorry, lots of conflicts here due to #1253 I promise I will review this if you resolve the conflicts. :) |
adamchainz
force-pushed
the
expressions
branch
from
5239987 to
5cee9ec
Compare
|
Rebased! Tests failed due to an apt issue, fix in #1313. |
intgr
approved these changes
Jan 9, 2023
| def __init__(self, *expressions: Any, output_field: Field | None = ..., **extra: Any) -> None: ... | ||
| def as_sql( | ||
| self, | ||
| expression: Expression | F | Subquery, |
There was a problem hiding this comment.
Reordering the classes here made it very difficult to understand what actually changed here. I had to order them back to get a readable diff.
In the future, if you want to reorder items, please do it as a separate PR without any additional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
GeoAggregateandGeoFuncMixinwhere the inherited types are correct**extra_contexttoFunc.as_sqlAgggregate.as_sqlsince it’s a pass-through toFunc.as_sqldb/models/expressions.pyito follow the same order as upstreamDurationExpression,TemporalSubtraction,Star, andOrderByListRelated issues
n/a
Spotted the problem with
Aggregatewhen adding Mypy to Django-MySQL, which has a custom aggregate class.