Improve types of as_sql() and as_<engine>() methods #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
force-pushed
the
fix-as_sql-and-as_engine
branch
from
f860731 to
625a94a
Compare
ngnpope
requested changes
Jan 9, 2023
intgr
commented
Jan 9, 2023
There was a problem hiding this comment.
Related: django/django#16437
There was a problem hiding this comment.
Damn. That was my typo 😂 Thanks for fixing!
|
This has been sitting for two weeks with no feedback. @ngnpope do you have time to do a review? |
ngnpope
approved these changes
Jan 25, 2023
intgr
force-pushed
the
fix-as_sql-and-as_engine
branch
from
3fd97c6 to
1b320cc
Compare
|
Rebased and typehinted |
|
Also fixed a failure detected by mypy-self-check, not sure why I didn't notice before. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Noticed this in #1243.