Remove deprecated requiresDOM setting #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Scala.js 0.6.20 our build displays this deprecation warning: ``` build.sbt:74: warning: value requiresDOM in object AutoImport is deprecated: Requesting a DOM-enabled JS env with `jsDependencies += RuntimeDOM` or `requiresDOM := true` will not be supported in Scala.js 1.x. Instead, explicitly select a suitable JS with `jsEnv`, e.g., `jsEnv := new org.scalajs.jsenv.jsdomnodejs.JSDOMNodeJSEnv`. requiresDOM := false, ^ ``` Since we are already selecting a DOM-disabled JS environment with ```sbt jsEnv := new org.scalajs.jsenv.nodejs.NodeJSEnv() ``` it seems to be enough to remove `requiresDOM` to get rid of this deprecation warning.
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 248 248
Lines 4352 4352
Branches 121 123 +2
=======================================
Hits 4142 4142
Misses 210 210Continue to review full report at Codecov.
|
kailuowang
approved these changes
Sep 6, 2017
|
merge with 1 sign-off as a straightforward build change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Scala.js 0.6.20 our build displays this deprecation warning:
Since we are already selecting a DOM-disabled JS environment with
it seems to be enough to remove
requiresDOMto get rid of thisdeprecation warning.