Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated requiresDOM setting #1892

Merged
merged 1 commit into from
Sep 6, 2017

Commits on Sep 6, 2017

  1. Remove deprecated requiresDOM setting

    Since Scala.js 0.6.20 our build displays this deprecation warning:
    
    ```
    build.sbt:74: warning: value requiresDOM in object AutoImport is
    deprecated: Requesting a DOM-enabled JS env with `jsDependencies +=
    RuntimeDOM` or `requiresDOM := true` will not be supported in Scala.js
    1.x. Instead, explicitly select a suitable JS with `jsEnv`, e.g., `jsEnv
    := new org.scalajs.jsenv.jsdomnodejs.JSDOMNodeJSEnv`.
      requiresDOM := false,
      ^
    ```
    
    Since we are already selecting a DOM-disabled JS environment with
    ```sbt
    jsEnv := new org.scalajs.jsenv.nodejs.NodeJSEnv()
    ```
    it seems to be enough to remove `requiresDOM` to get rid of this
    deprecation warning.
    fthomas committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    1e06654 View commit details
    Browse the repository at this point in the history