standardise on `liftF` and add `liftK` to transformers #2033

SystemFw · 2017-11-20T23:45:30Z

This PR deprecates lift on all transformers in favour of liftF, and adds a FunctionK version named liftK (for use with mapK).

I'm leaving a possible scalafix to a separate PR.

kailuowang · 2017-11-21T02:17:34Z

core/src/main/scala/cats/data/IndexedReaderWriterStateT.scala

+      def apply[A](fa: F[A]): IndexedReaderWriterStateT[F, E, L, S, S, A] = IndexedReaderWriterStateT.liftF(fa)
+    }
+
+  @deprecated("Use liftF instead", "1.0.0-RC2")


There probably won't be a rc2, the next one is 1.0

Yeah, wasn't quite sure. I'll fix tomorrow

SystemFw · 2017-11-21T17:00:03Z

Fixed the RC deprecation warning. I'm adding the scalafix now (changed my mind, I'll do it in this PR)

kailuowang · 2017-11-21T18:08:31Z

also need some mima exclusion

�[0m[�[31merror�[0m] �[0m filter with: ProblemFilters.excludeReversedMissingMethodProblem�[0m
�[0m[�[31merror�[0m] �[0m * method liftK(cats.Applicative,cats.kernel.Monoid)cats.arrow.FunctionK in trait cats.data.CommonIRWSTConstructors is present only in current version�[0m
�[0m[�[31merror�[0m] �[0m filter with: ProblemFilters.excludeReversedMissingMethodProblem�[0m
�[0m[�[31merror�[0m] �[0m * method liftF(java.lang.Object)cats.data.Kleisli in trait cats.data.KleisliFunctions is present only in current version�[0m
�[0m[�[31merror�[0m] �[0m filter with: ProblemFilters.excludeReversedMissingMethodProblem�[0m
�[0m[�[31merror�[0m] �[0m * method liftK()cats.arrow.FunctionK in trait cats.data.KleisliFunctions is present only in current version�[0m
�[0m[�[31merror�[0m] �[0m filter with: ProblemFilters.excludeReversedMissingMethodProblem�[0m
�[0m[�[31merror�[0m] �[0m * method liftF(java.lang.Object,cats.Applicative)cats.data.IndexedStateT in trait cats.data.CommonStateTConstructors is present only in current version�[0m
�[0m[�[31merror�[0m] �[0m filter with: ProblemFilters.excludeReversedMissingMethodProblem�[0m
�[0m[�[31merror�[0m] �[0m * method liftK(cats.Applicative)cats.arrow.FunctionK in trait cats.data.CommonStateTConstructors is present only in current version�[0m
�[0m[�[31merror�[0m] �[0m filter with: ProblemFilters.excludeReversedMissingMethodProblem�[0m

SystemFw · 2017-11-21T18:09:52Z

@kailuowang Any quick reference to how you exclude something from MiMa or should I RTFM? :)

LukaJCB · 2017-11-21T18:18:47Z

@SystemFw You can add them right here: https://github.com/typelevel/cats/blob/master/build.sbt#L212 :)

SystemFw · 2017-11-21T18:27:03Z

Thanks a lot! @LukaJCB

aeons · 2017-11-22T09:20:58Z

This is great. I've had to write the OptionT variant several times lately.

Is there a reason you're not using the kind-projector syntax?

def liftK[F[_]](implicit F: Functor[F]): F ~> OptionT[F, ?] = 
  λ[F ~> OptionT[F, ?]](OptionT.liftF(_))

(or Lambda instead of λ)

SystemFw · 2017-11-22T10:47:41Z

@aeons Yes, http4s was the initial use case :)

There's no reason for not using it, I might change it as I fix the other things

SystemFw · 2017-11-23T01:25:01Z

I think I'm mostly done, except my scalafix test doesn't compile ( it's telling me that RWST is not a member of cats.data ).
This happens because the scalafix is running on 0.9.0, and RWST was introduced later. How should I proceed?

P.S. the error in the travis seems spurious

kailuowang · 2017-11-23T03:05:47Z

the migration is for migrating from 0.9. ideally we need a new set of migration that migrates from 1.0 RC1, although I am not sure a simple rename in RWST justify that. I propose we just remove RWST from the test.

codecov-io · 2017-11-23T15:03:15Z

Codecov Report

Merging #2033 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
- Coverage   95.15%   94.98%   -0.18%     
==========================================
  Files         305      311       +6     
  Lines        5184     5267      +83     
  Branches      125      122       -3     
==========================================
+ Hits         4933     5003      +70     
- Misses        251      264      +13

Impacted Files	Coverage Δ
core/src/main/scala/cats/data/IndexedStateT.scala	`98.8% <100%> (-1.2%)`	⬇️
core/src/main/scala/cats/data/EitherT.scala	`97.6% <100%> (+0.01%)`	⬆️
core/src/main/scala/cats/data/Kleisli.scala	`97.59% <100%> (-1.18%)`	⬇️
core/src/main/scala/cats/data/WriterT.scala	`93.75% <100%> (-0.94%)`	⬇️
core/src/main/scala/cats/data/OptionT.scala	`100% <100%> (ø)`	⬆️
...in/scala/cats/data/IndexedReaderWriterStateT.scala	`99.06% <100%> (-0.94%)`	⬇️
core/src/main/scala/cats/Traverse.scala	`100% <0%> (ø)`	⬆️
core/src/main/scala/cats/Foldable.scala	`100% <0%> (ø)`	⬆️
...ain/scala/cats/laws/discipline/TraverseTests.scala	`100% <0%> (ø)`	⬆️
...a/cats/laws/discipline/NonEmptyTraverseTests.scala	`100% <0%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cff547...e68cade. Read the comment docs.

SystemFw · 2017-11-23T15:55:46Z

@kailuowang I think the errors are spurious and I should be done. The scalafix has fixes for both 0.9 and 1.0RC, the RC ones are not tested as discussed above

SystemFw · 2017-11-24T15:54:16Z

Some of the builds fail with

Could not find any member to link for "mapK"

should I address this?

LukaJCB · 2017-11-24T15:57:49Z

That seems odd, seems like an error during scaladoc compilation. Maybe someone else has an idea?

SystemFw · 2017-11-24T15:59:36Z

Yeah, I reference [[mapK]] in a scaladoc, might be a pretty stupid error ? . Can't really test locally since MiMa fails before on my machine ("versions not set" so it's my setup, it succeeds on Travis)

LukaJCB · 2017-11-24T16:03:24Z

I think it might be because mapK is on the instance while liftF is on the companion object, so they need to be referred to differently. Not sure how exactly though.

SystemFw · 2017-11-24T16:05:10Z

I think we agree on what the problem is then :)
I also think we agree in not knowing what the solution is :P
I'll investigate (this sort of search and replace PRs always end up taking ages for me)

kailuowang · 2017-11-24T16:08:01Z

Linking reference in scaladoc has always been problematic, the solutions people have been doing in the past, and I propose doing here, is to just remove the link.

SystemFw · 2017-11-24T16:18:10Z

so just mapK rather than [[mapK]] ? Sounds good to me :)

SystemFw · 2017-11-25T00:54:15Z

I need to fix the doctest for kleisli. It's the only bit of codecov that actually spotted a problem. Doing so right now

LukaJCB

Thanks!

frroliveira · 2017-11-25T11:49:41Z

If you're still interested in getting the scaladoc references working, you can prefix mapK with the class name, e.g. EitherT.mapK. That's what I used in IorT.liftK

kailuowang · 2017-11-25T13:27:24Z

Close and reopen to trigger build

kailuowang reviewed Nov 21, 2017

View reviewed changes

kailuowang added the Source Breaking label Nov 21, 2017

kailuowang added this to the 1.0.0 milestone Nov 21, 2017

SystemFw added 5 commits November 22, 2017 23:52

Deprecate lift in favour of liftF

c7f0589

Add liftK to Monad Transformers

f35dd9a

Correct version number in deprecation warning

64c1eb0

Add scalafix to rename lift to liftF

be784fa

Use kind projector syntax for liftK

0fed5ea

SystemFw force-pushed the feature/liftF branch from 4d4fbb2 to e136974 Compare November 22, 2017 23:53

Add MiMa exceptions

e136974

Fix scalafix

50b24d8

Fix broken scaladoc link

ea6187b

kailuowang previously approved these changes Nov 25, 2017

View reviewed changes

SystemFw dismissed kailuowang’s stale review via e8a4eed November 25, 2017 00:58

SystemFw and others added 2 commits November 25, 2017 01:00

Fix doctest for Kleisli's liftK

e8a4eed

Merge branch 'master' into feature/liftF

e68cade

LukaJCB approved these changes Nov 25, 2017

View reviewed changes

kailuowang closed this Nov 25, 2017

kailuowang reopened this Nov 25, 2017

LukaJCB approved these changes Nov 25, 2017

View reviewed changes

LukaJCB mentioned this pull request Nov 26, 2017

Get ready for RC2 #2044

Merged

3 tasks

kailuowang approved these changes Nov 27, 2017

View reviewed changes

kailuowang merged commit 977d41e into typelevel:master Nov 27, 2017

kailuowang added the enhancement label Dec 14, 2017

oleg-py mentioned this pull request Dec 26, 2017

Iterant.liftF (F[A] => Iterant[F, A]) builder monix/monix#487

Closed

LukaJCB mentioned this pull request Aug 5, 2018

unify lift between all of the transformers all liftT methods #1681

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

standardise on `liftF` and add `liftK` to transformers #2033

standardise on `liftF` and add `liftK` to transformers #2033

SystemFw commented Nov 20, 2017

kailuowang Nov 21, 2017

SystemFw Nov 21, 2017

SystemFw commented Nov 21, 2017

kailuowang commented Nov 21, 2017

SystemFw commented Nov 21, 2017

LukaJCB commented Nov 21, 2017

SystemFw commented Nov 21, 2017

aeons commented Nov 22, 2017

SystemFw commented Nov 22, 2017

SystemFw commented Nov 23, 2017

kailuowang commented Nov 23, 2017

codecov-io commented Nov 23, 2017 •

edited

Loading

SystemFw commented Nov 23, 2017 •

edited

Loading

SystemFw commented Nov 24, 2017

LukaJCB commented Nov 24, 2017

SystemFw commented Nov 24, 2017 •

edited

Loading

LukaJCB commented Nov 24, 2017

SystemFw commented Nov 24, 2017

kailuowang commented Nov 24, 2017

SystemFw commented Nov 24, 2017 •

edited

Loading

SystemFw commented Nov 25, 2017

LukaJCB left a comment

frroliveira commented Nov 25, 2017

kailuowang commented Nov 25, 2017

standardise on liftF and add liftK to transformers #2033

standardise on liftF and add liftK to transformers #2033

Conversation

SystemFw commented Nov 20, 2017

kailuowang Nov 21, 2017

Choose a reason for hiding this comment

SystemFw Nov 21, 2017

Choose a reason for hiding this comment

SystemFw commented Nov 21, 2017

kailuowang commented Nov 21, 2017

SystemFw commented Nov 21, 2017

LukaJCB commented Nov 21, 2017

SystemFw commented Nov 21, 2017

aeons commented Nov 22, 2017

SystemFw commented Nov 22, 2017

SystemFw commented Nov 23, 2017

kailuowang commented Nov 23, 2017

codecov-io commented Nov 23, 2017 • edited Loading

Codecov Report

SystemFw commented Nov 23, 2017 • edited Loading

SystemFw commented Nov 24, 2017

LukaJCB commented Nov 24, 2017

SystemFw commented Nov 24, 2017 • edited Loading

LukaJCB commented Nov 24, 2017

SystemFw commented Nov 24, 2017

kailuowang commented Nov 24, 2017

SystemFw commented Nov 24, 2017 • edited Loading

SystemFw commented Nov 25, 2017

LukaJCB left a comment

Choose a reason for hiding this comment

frroliveira commented Nov 25, 2017

kailuowang commented Nov 25, 2017

standardise on `liftF` and add `liftK` to transformers #2033

standardise on `liftF` and add `liftK` to transformers #2033

codecov-io commented Nov 23, 2017 •

edited

Loading

SystemFw commented Nov 23, 2017 •

edited

Loading

SystemFw commented Nov 24, 2017 •

edited

Loading

SystemFw commented Nov 24, 2017 •

edited

Loading