2228-add MonadError instance for optionT where F is a Monad #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Jun 18, 2018
| @@ -287,6 +290,29 @@ private[data] trait OptionTMonad[F[_]] extends Monad[OptionT[F, ?]] { | |||
| ))) | |||
| } | |||
|
|
|||
| private[data] trait OptionTMonadErrorMonad[F[_]] extends MonadError[OptionT[F, ?], Unit] { | |||
There was a problem hiding this comment.
Wondering if it'd be possible to extend OptionTMonad[F] here to reduce duplication (like the trait below does).
There was a problem hiding this comment.
I see.. You are right. I should have mixin OptionTMonad[F]. Changing it..
Codecov Report
@@ Coverage Diff @@
## master #2299 +/- ##
==========================================
+ Coverage 95.05% 95.06% +<.01%
==========================================
Files 338 338
Lines 5850 5860 +10
Branches 220 221 +1
==========================================
+ Hits 5561 5571 +10
Misses 289 289
Continue to review full report at Codecov.
|
johnynek
approved these changes
Jun 18, 2018
kailuowang
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2228