Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatTransform to OptionT (Issue #2309) #2313

Closed
wants to merge 1 commit into from
Closed

Add flatTransform to OptionT (Issue #2309) #2313

wants to merge 1 commit into from

Conversation

sh-abhi
Copy link

@sh-abhi sh-abhi commented Jul 6, 2018

As suggested by @amilkov3 and @kubukoz.

Referencing #2309

@sh-abhi sh-abhi changed the title Add flatTransform to OptionT #2309 Add flatTransform to OptionT (Issue #2309) Jul 6, 2018
@codecov-io
Copy link

codecov-io commented Jul 6, 2018

Codecov Report

Merging #2313 into master will increase coverage by 0.29%.
The diff coverage is 94.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2313      +/-   ##
==========================================
+ Coverage   94.73%   95.03%   +0.29%     
==========================================
  Files         338      338              
  Lines        5868     5879      +11     
  Branches      213      212       -1     
==========================================
+ Hits         5559     5587      +28     
+ Misses        309      292      -17
Impacted Files Coverage Δ
core/src/main/scala/cats/Foldable.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/Bitraverse.scala 80% <ø> (ø) ⬆️
core/src/main/scala/cats/data/EitherT.scala 97.7% <100%> (ø) ⬆️
core/src/main/scala/cats/syntax/binested.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Binested.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/syntax/parallel.scala 72.72% <100%> (ø) ⬆️
core/src/main/scala/cats/syntax/set.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptySet.scala 98.75% <100%> (ø) ⬆️
laws/src/main/scala/cats/laws/discipline/Eq.scala 94.33% <100%> (ø) ⬆️
.../src/main/scala/cats/syntax/applicativeError.scala 100% <100%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ef0e9...cc4eef5. Read the comment docs.

@kubukoz
Copy link
Member

kubukoz commented Jul 6, 2018

Looks like you got some changes unrelated to the issue here... Including #2299, #2285 etc. - can you create a new branch that only has your changes, and create a new PR?

@johnynek
Copy link
Contributor

johnynek commented Jul 6, 2018

+1 to separate PRs here. Each can be reviewed and merged on their own schedule.

@johnynek
Copy link
Contributor

johnynek commented Jul 6, 2018

On second look, this looks like some GitHub issue. Can you rebase on master?

@sh-abhi
Copy link
Author

sh-abhi commented Jul 7, 2018

@kubukoz @johnynek Closing this and opened a new one: #2314.

@sh-abhi sh-abhi closed this Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants