-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unzip to Functor #3062
add unzip to Functor #3062
Conversation
I need some help with this weird compiler situation
the current version won't compile, but if I just introduce a dummy parameter to unzip method, it works just fine.
Similarly if I remove the |
@gagandeepkalra looks like an issue with Simulacrum-generated extension method (from Annotating |
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
+ Coverage 93.17% 93.17% +<.01%
==========================================
Files 372 372
Lines 7182 7183 +1
Branches 198 188 -10
==========================================
+ Hits 6692 6693 +1
Misses 490 490
Continue to review full report at Codecov.
|
@oleg-py yes thank you, this fixes the compilation. I'm not so sure of the bincompat, I still get this error
compiler suggested I add the above line to build.sbt, so I did, but I'm not very this is the right way. |
@LukaJCB @kailuowang some eyes on this one please |
Sorry I just realized the review comments I left earlier was in pending status and not actually posted. I suggested that it's odd that the mima bin compat check failed. I am curious, have you merged in the master? |
@kailuowang @oleg-py I updated the method signature.
This fixed the Simulacrum error, we won't need |
# Conflicts: # core/src/main/scala/cats/Functor.scala
If I am not mistaken this relies on the implicit |
yes, agreed. I was trying to avoid using |
This looks fine to me. |
Thank you everyone |
(accidentally closed and reopened pr with an incomplete comment...) @travisbrown As I was saying, the original attempt was a direct fix in the Functor trait that work with Simulacrum so it would be slightly beneficial if the intention is to move as much back to a single typeclass/trait when bincompat isn't an issue. However, having On a side note regarding #3062 (comment) , having the type signature of def widen[A, B: A <:< *](fa: F[A]): F[B] = fa.asInstanceOf[F[B]] would fix(i.e. not require |
addresses #3023