Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.1.0 changes for Scala 2.11 #3143

Closed
15 of 22 tasks
travisbrown opened this issue Nov 13, 2019 · 3 comments
Closed
15 of 22 tasks

Backport 2.1.0 changes for Scala 2.11 #3143

travisbrown opened this issue Nov 13, 2019 · 3 comments

Comments

@travisbrown
Copy link
Contributor

travisbrown commented Nov 13, 2019

As explained here and in the Cats 2019 roadmap, we dropped support for Scala 2.11 on the Cats master branch after the 2.0.0 release, and we're relying on Scala 2.11 users to backport features from master to the scala_2.11 branch for all future Cats releases.

We're planning to publish Cats 2.1.0-RC1 this Friday (15 November) and 2.1.0 by the end of this month. I've backported many of the build config changes and dependency updates to the 2.11 branch, but there are still many features that need to be backported in order for us to publish Cats 2.1.0 for Scala 2.11 (we're not necessarily aiming for 100% source compatibility between the 2.11 and 2.12 releases, but want to be close).

Note that many of the changes listed below are substantially more difficult to make on Scala 2.11 than on 2.12+ because adding methods to traits on 2.11 breaks binary compatibility (which is why we dropped decided to drop 2.11 support on master in the first place 😄). You can see an example of what's necessary in this pre-2.0 PR adding an ifA method for Apply.

Pull requests currently merged on master that still need to be backported:

Not yet merged but likely to be in 2.1.0-RC1:

I'll keep these checklists updated, and you can find a complete list of what will be included in 2.1.0-RC1 in the milestone.

If most of these PRs aren't backported by the end of the month, it's unlikely that we'll publish Cats 2.1.0 for Scala 2.11. (We will continue to publish 2.0.x bugfix releases for Scala 2.11, and 2.1.0 will be backwards binary-compatible with 2.0, so even if we do drop 2.11 support in 2.1.0, that generally shouldn't cause major problems for Cats users who are still on Scala 2.11.)

Please comment here to let us know if you're working on backporting any of these changes, and please feel free to request reviews or other feedback from me or other Cats maintainers for backport PRs.

@gagandeepkalra
Copy link
Contributor

@travisbrown is #3135 the correct Pull request for Add foldMapA, because I see another one there #3130, please confirm.

@gagandeepkalra
Copy link
Contributor

Hello, I'm done with all of them, below is listed the status of those for which I didn't raise a PR.

Add ifF to Functor: #3040 => PR is already open #3131
Fix Vector instances: #3100 => This was reverted for broken BC
Fix Eq instances for tuples: #3105 => This was reverted for broken BC
Add foldMapA: #3135 => Need clarification, see comment here
Fix NonEmptyChain.fromSeq signature: #3133 => PR is already open #3134
Move adaptError: #3148 => Already available in 2.11

@larsrh
Copy link
Contributor

larsrh commented Jan 30, 2021

I'm closing all 2.11-related tickets since there is not enough community interest in further releases.

@larsrh larsrh closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants