Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport bifold in Bifoldable typeclass to scala_2.11 #3242

Merged

Conversation

gagandeepkalra
Copy link
Contributor

@gagandeepkalra gagandeepkalra commented Jan 9, 2020

addresses #3143

@gagandeepkalra
Copy link
Contributor Author

I was hoping to augment this PR with another Bifoldable law, but couldn't get around binary compatibility. I settled with a doctest for now.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple consistency nits, but the substance looks good.

core/src/main/scala/cats/syntax/bifoldable.scala Outdated Show resolved Hide resolved
core/src/main/scala/cats/syntax/bifoldable.scala Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #3242 into scala_2.11 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3242      +/-   ##
==============================================
+ Coverage        93.5%   93.51%   +<.01%     
==============================================
  Files             383      384       +1     
  Lines            7149     7151       +2     
  Branches          193      192       -1     
==============================================
+ Hits             6685     6687       +2     
  Misses            464      464
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/bifoldable.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7890320...824862c. Read the comment docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. I overlooked the update to this. 👍

@rossabaker rossabaker merged commit e37485f into typelevel:scala_2.11 Feb 4, 2020
@gagandeepkalra gagandeepkalra deleted the backport/bifoldable/bifold branch February 4, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants