Backport #3146 Add redeem and redeemWith #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## scala_2.11 #3348 +/- ##
==============================================
- Coverage 93.46% 93.43% -0.03%
==============================================
Files 385 385
Lines 7162 7164 +2
Branches 197 196 -1
==============================================
Hits 6694 6694
- Misses 468 470 +2
Continue to review full report at Codecov.
|
gagandeepkalra
changed the title
travisbrown
approved these changes
Mar 10, 2020
|
|
||
| def raiseError[A](e: Throwable): Future[A] = Future.failed(e) | ||
| override def handleError[A](fea: Future[A])(f: Throwable => A): Future[A] = fea.recover { case t => f(t) } | ||
| override def handleError[A](fea: Future[A])(f: Throwable => A): Future[A] = |
There was a problem hiding this comment.
There are no actual changes in this file, right?
There was a problem hiding this comment.
yes, only formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one had few stuff to backport;
since we are not porting consistency law over, see here
and cannot override for specific instances now given we had to maintain BC while implementing, see here
addresses #3143