Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3041 tailrec instances for StackSafeMonad and Defer to scala_2.11 #3332

Conversation

gagandeepkalra
Copy link
Contributor

@gagandeepkalra gagandeepkalra commented Feb 29, 2020

addresses #3143

@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

Merging #3332 into scala_2.11 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3332      +/-   ##
==============================================
+ Coverage       93.42%   93.43%   +<.01%     
==============================================
  Files             385      386       +1     
  Lines            7165     7173       +8     
  Branches          191      186       -5     
==============================================
+ Hits             6694     6702       +8     
  Misses            471      471
Impacted Files Coverage Δ
core/src/main/scala/cats/Eval.scala 98.87% <100%> (+0.01%) ⬆️
core/src/main/scala/cats/instances/tailrec.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8227961...3de5cd1. Read the comment docs.

@gagandeepkalra gagandeepkalra changed the title Backported tailrec instances for StacksafeMonad and Defer to scala_2.11 Backported tailrec instances for StackSafeMonad and Defer to scala_2.11 Feb 29, 2020
@gagandeepkalra gagandeepkalra changed the title Backported tailrec instances for StackSafeMonad and Defer to scala_2.11 Backported #3041 tailrec instances for StackSafeMonad and Defer to scala_2.11 Feb 29, 2020
@travisbrown travisbrown self-requested a review February 29, 2020 16:28
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MiMa says it's okay it looks good to me.

@gagandeepkalra gagandeepkalra changed the title Backported #3041 tailrec instances for StackSafeMonad and Defer to scala_2.11 Backport #3041 tailrec instances for StackSafeMonad and Defer to scala_2.11 Mar 1, 2020
@travisbrown travisbrown merged commit 8e50b78 into typelevel:scala_2.11 Mar 11, 2020
@gagandeepkalra gagandeepkalra deleted the backport/tailRecInstances/stackSafeMonad branch March 11, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants