-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Order constraint from Hash instance for Map #3126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3126 +/- ##
==========================================
- Coverage 93.22% 93.19% -0.03%
==========================================
Files 375 375
Lines 7291 7294 +3
Branches 196 192 -4
==========================================
+ Hits 6797 6798 +1
- Misses 494 496 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
…ance for `SortedSet`
This PR includes the commits by @vasiliybondarenko and @larsrh from #3060 but cleans up some of the deprecation messages, and also uses an override instead of a new name with a
1
suffix. I've also added a few lines of documentation explaining why the horribleoverride
stuff incats.instances.sortedSet
is necessary.