Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-microsites #3218

Merged
merged 4 commits into from
Dec 18, 2019
Merged

Conversation

travisbrown
Copy link
Contributor

I started migrating from Tut to mdoc but it doesn't feel practical:

  • We rely very heavily on redefinition. I started putting things in wrapper objects or adding suffixes but when you have half a dozen iterations of def combineAll or whatever this really hurts readability (in some cases :reset is an option but in most it's not).
  • We have one reasonable use of nofail.

There's probably other stuff but that's where I gave up.

I do think we should update sbt-microsites sooner rather than later, though, so I've made the bump and specifically set WithTut and the old theme. I built it locally and everything looks fine.

I also updated Jekyll in the Travis CI config, because I did a similar update for Circe this morning and being on an old version of Jekyll caused problems in a non-obvious way that was a huge pain to debug.

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #3218 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
- Coverage   93.38%   93.05%   -0.34%     
==========================================
  Files         372      376       +4     
  Lines        7224     7412     +188     
  Branches      179      192      +13     
==========================================
+ Hits         6746     6897     +151     
- Misses        478      515      +37
Flag Coverage Δ
#scala_version_212 93.38% <ø> (ø) ⬆️
#scala_version_213 92.82% <ø> (?)
Impacted Files Coverage Δ
...e/src/main/scala-2.13+/cats/data/ZipLazyList.scala 77.77% <0%> (ø)
...src/main/scala-2.13+/cats/instances/lazyList.scala 100% <0%> (ø)
....13+/cats/kernel/instances/LazyListInstances.scala 100% <0%> (ø)
.../main/scala-2.13+/cats/data/NonEmptyLazyList.scala 62.5% <0%> (ø)
...in/scala/cats/data/AbstractNonEmptyInstances.scala 100% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9624f5c...a6a4293. Read the comment docs.

LukaJCB
LukaJCB previously approved these changes Dec 18, 2019
@travisbrown travisbrown merged commit c752844 into typelevel:master Dec 18, 2019
gagandeepkalra added a commit to gagandeepkalra/cats that referenced this pull request Jan 4, 2020
gagandeepkalra added a commit to gagandeepkalra/cats that referenced this pull request Jan 4, 2020
rossabaker pushed a commit that referenced this pull request Jan 6, 2020
* backported #3218 to fix `sbt docs/makeMicrosite`

* attempting to fix 403's in dependency fetching by disabling coursier for docs

* reverted disabling coursier for docs (the 403's fixed themselves somehow)
@jhnsmth jhnsmth mentioned this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants