Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport #3218 to scala_2.11, fixes error with sbt-microsites #3238

Merged

Conversation

gagandeepkalra
Copy link
Contributor

No description provided.

@rossabaker
Copy link
Member

I'm not sure why the build is failing. I noticed this tweet about 403s, but I would think caching $HOME/.cache already covers the recommendation there.

@codecov-io
Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #3238 into scala_2.11 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           scala_2.11   #3238   +/-   ##
==========================================
  Coverage        93.5%   93.5%           
==========================================
  Files             382     382           
  Lines            7147    7147           
  Branches          194     194           
==========================================
  Hits             6683    6683           
  Misses            464     464

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc2c49...24a39d7. Read the comment docs.

@rossabaker
Copy link
Member

I should have thought of this earlier, but we could probably disable the site generation altogether on this branch. I don't think we intend to publish the site from it. It increases the divergence from the main branch, which is bad, but it also cuts off something that tends to bitrot, which is good.

Generating the scaladoc is still a requirement for Maven Central, so it probably makes sense to run sbt doc (but not unidoc) in Travis, and fix the errors from that last build.

@gagandeepkalra
Copy link
Contributor Author

@rossabaker I think the publishMicrosite is only enabled from master already.

The build fixed itself somehow, should I still go ahead and update .travis.yml to include just docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like publishing is only from master, but building the microsite still happens on the branch. The microsite is unneeded work that risks bitrot, but every change on this branch risks future merge conflicts. I'd say don't mess with green, but let's keep that change in mind if the microsite rots again.

@travisbrown travisbrown self-requested a review January 6, 2020 13:14
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@rossabaker rossabaker merged commit 4a7be5d into typelevel:scala_2.11 Jan 6, 2020
@gagandeepkalra gagandeepkalra deleted the backport/update_sbt-microsites branch January 6, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants