-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport #3218 to scala_2.11, fixes error with sbt-microsites
#3238
backport #3218 to scala_2.11, fixes error with sbt-microsites
#3238
Conversation
8a71856
to
ee47262
Compare
I'm not sure why the build is failing. I noticed this tweet about 403s, but I would think caching |
Codecov Report
@@ Coverage Diff @@
## scala_2.11 #3238 +/- ##
==========================================
Coverage 93.5% 93.5%
==========================================
Files 382 382
Lines 7147 7147
Branches 194 194
==========================================
Hits 6683 6683
Misses 464 464 Continue to review full report at Codecov.
|
I should have thought of this earlier, but we could probably disable the site generation altogether on this branch. I don't think we intend to publish the site from it. It increases the divergence from the main branch, which is bad, but it also cuts off something that tends to bitrot, which is good. Generating the scaladoc is still a requirement for Maven Central, so it probably makes sense to run |
@rossabaker I think the The build fixed itself somehow, should I still go ahead and update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like publishing is only from master, but building the microsite still happens on the branch. The microsite is unneeded work that risks bitrot, but every change on this branch risks future merge conflicts. I'd say don't mess with green, but let's keep that change in mind if the microsite rots again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
No description provided.