Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Either.unit, use in Applicative[Either[A, ?]] #3346

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

rossabaker
Copy link
Member

Fixes #3343. Thanks to @sirthias for the idea.

@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #3346 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3346      +/-   ##
==========================================
+ Coverage   93.32%   93.33%   +<.01%     
==========================================
  Files         378      378              
  Lines        7689     7692       +3     
  Branches      206      203       -3     
==========================================
+ Hits         7176     7179       +3     
  Misses        513      513
Flag Coverage Δ
#scala_version_212 93.38% <100%> (+0.02%) ⬆️
#scala_version_213 93.11% <100%> (ø) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/either.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/syntax/either.scala 83.33% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc23079...8ad87cd. Read the comment docs.

@travisbrown travisbrown added this to the 2.2.0-M1 milestone Mar 10, 2020
@travisbrown travisbrown self-requested a review March 10, 2020 08:04
@travisbrown travisbrown merged commit 222bd5a into master Mar 10, 2020
@larsrh larsrh deleted the issue-3343 branch April 11, 2020 09:47
@armanbilge armanbilge mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Either.unit
4 participants