Add Validated.unit
#4420
Add Validated.unit
#4420
Conversation
VladKopanev
changed the title
Validated.unit method to expose cached valid unit valueValidated.unit
| /** | ||
| * Cached value of `Valid(())` to avoid allocations for a common case. | ||
| */ | ||
| final def unit[E]: Validated[E, Unit] = Validated.validUnit |
There was a problem hiding this comment.
Thanks! Do we need the type parameter to help with inference or would Validated[Nothing, Unit] work fine?
There was a problem hiding this comment.
Not really sure, I followed an example from Either.unit for consistency.
There was a problem hiding this comment.
In some obscure cases, it might help, actually, but I don't know off the top of my head
There was a problem hiding this comment.
I see, I didn't find any clues in #3346. Either.unit works well enough so this seems fine then :)
There was a problem hiding this comment.
Yeah, hard to say. I also wondered if its an artifact of old compilers e.g. 2.11 that couldn't handle these as well.
There was a problem hiding this comment.
Possibly yes, I remember stumbling upon such cases a few years back with zio-saga library, but not sure any more if this behaviour still exists in modern versions.
No description provided.