-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change review policy for PRs that don't target master #3354
Change review policy for PRs that don't target master #3354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3354 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 378 378
Lines 7692 7692
Branches 206 206
=======================================
Hits 7179 7179
Misses 513 513
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I've also been trying to help out on those, but my OSS time ebbs and flows, and this strikes a good balance to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 sounds good to me
Great, thanks all! |
Thank you @travisbrown for everything |
I originally proposed this policy change on Gitter:
…but on second thought it seems easiest just to make the change as a PR and we can discuss it here.