Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change review policy for PRs that don't target master #3354

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

travisbrown
Copy link
Contributor

I originally proposed this policy change on Gitter:

I'd like to propose that we lower the review requirement for non-master PRs in Cats.

Specifically Gagandeep has put a huge amount of effort into backporting 2.1 changes for Scala 2.11, and these contributions have been getting merged very slowly: https://github.com/typelevel/cats/pulls?q=is%3Apr+author%3Agagandeepkalra+backport

There are currently 10 open. I've reviewed all of them, and in a few cases we've gone through several iterations to get them right.

I know backport branches like this are a low priority for most maintainers (including me), but they can be very important for contributors like Gagandeep, and I think it would be reasonable to say PRs against these branches only need one non-author +1 to merge.

…but on second thought it seems easiest just to make the change as a PR and we can discuss it here.

@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #3354 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3354   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files         378      378           
  Lines        7692     7692           
  Branches      206      206           
=======================================
  Hits         7179     7179           
  Misses        513      513           
Flag Coverage Δ
#scala_version_212 93.38% <ø> (ø)
#scala_version_213 93.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d49b4...d78d983. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've also been trying to help out on those, but my OSS time ebbs and flows, and this strikes a good balance to me.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sounds good to me

@travisbrown
Copy link
Contributor Author

Great, thanks all!

@travisbrown travisbrown merged commit e3dc36a into typelevel:master Mar 11, 2020
@gagandeepkalra
Copy link
Contributor

Thank you @travisbrown for everything

@travisbrown travisbrown added this to the 2.2.0-M1 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants