Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change review policy for PRs that don't target master #3354

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Change review policy for PRs that don't target master #3354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions PROCESS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ When fixing typos, improving documentation or minor build fix only
one sign-off is required (although for major edits waiting for two
may be preferable).

In some cases pull requests that don't target the master branch may be
merged with a single sign-off from a maintainer (as long as they
aren't also the author of the pull request). For example, backporting
changes from master to the `scala_2.11` branch generally shouldn't
require multiple reviews. If either the pull request author or a Cats
maintainer thinks that a specific change should receive multiple
approvals even though it doesn't target the master branch, their
request should be respected.

For serious emergencies or work on the build which can't easily be
reviewed or tested, pushing directly to master may be OK (but is
definitely not encouraged). In these cases it's best to comment in
Expand Down