Mark Ops traits as Serializable #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3440 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 381 381
Lines 8272 8272
Branches 225 227 +2
=======================================
Hits 7581 7581
Misses 691 691 |
larsrh
previously approved these changes
May 29, 2020
djspiewak
previously approved these changes
May 29, 2020
travisbrown
force-pushed
the
topic/serializable-ops
branch
from
47c4679
to
a6dcb17
Compare
travisbrown
force-pushed
the
topic/serializable-ops
branch
from
a6dcb17
to
00d7462
Compare
|
Okay, the new Simulacrum Scalafix release is out, so this can be merged and I've just un-drafted it. Someone mind making a fresh approval? |
larsrh
approved these changes
May 31, 2020
LukaJCB
approved these changes
May 31, 2020
kailuowang
approved these changes
May 31, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of the issue noted by @ceedubs in #3439 more generally. This is a draft PR only because I used a locally-published version of Scalafix Simulacrum to make it. It's ready for review, and can be merged if this PR is merged and released as 0.3.0.