Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Ops traits as Serializable #29

Merged
merged 1 commit into from
May 29, 2020
Merged

Conversation

travisbrown
Copy link
Contributor

The Ops traits generated by Simulacrum have never been marked Serializable, which can cause problems on Spark. We could make this an option but right now that seems like unnecessary complexity.

The important part here is adding Serializable to the Ops traits. I've also done the ToXOps ones for consistency, but I'm hoping we can deprecate them soon anyway.

@codecov-commenter
Copy link

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files           9        9           
  Lines         336      336           
  Branches        6        6           
=======================================
  Hits          268      268           
  Misses         68       68           
Impacted Files Coverage Δ
...rg/typelevel/simulacrum/fix/TypeClassSupport.scala 90.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2dd1f...20dd84b. Read the comment docs.

@travisbrown travisbrown merged commit d9f4e34 into master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants