Revert implicitness of Empty.fromEmptyK #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks kittens But more importantly, `MonoidK -> Monoid` and `SemigroupK -> Semigroup` are not implicit either. I would err on the side of consistency here.
barambani
approved these changes
Feb 13, 2021
LukaJCB
approved these changes
Feb 14, 2021
|
Do we need another hotfix release? 😅 |
I think not - nobody has complained yet and there is no rush to update cats in kittens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks kittens: typelevel/kittens#299
PR that made it implicit: #3677
But more importantly,
MonoidK -> MonoidandSemigroupK -> Semigroupare not implicit either. I would err on the side of consistency here.