Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cats.compat a package object for for2_13Use3 compatibility #4315

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Make cats.compat a package object for for2_13Use3 compatibility #4315

merged 2 commits into from
Oct 12, 2022

Conversation

TonioGela
Copy link
Member

@TonioGela TonioGela commented Oct 7, 2022 •
edited
Loading

Hello! This should address #4304 in a bincompat way. Thanks to @bishabosha for the suggestion in #4304 (comment)

It was tested publishing the dep locally using the same scala-cli script mentioned in the issue

//> using scala "2.13.8"

//> using option "-Ytasty-reader"

//> using lib "org.typelevel:cats-core_3:2.8.0"

import cats.syntax.all._

object Main extends App {

}

@TonioGela TonioGela changed the title Recreated compat as a package object Recreated compat as a package object in scala_3 to make the artifact usable from scala 2 Oct 7, 2022
armanbilge
armanbilge reviewed Oct 7, 2022
View reviewed changes
mima.sbt Outdated Show resolved Hide resolved
@armanbilge armanbilge added the bug label Oct 7, 2022
@armanbilge armanbilge added this to the 2.9.0 milestone Oct 7, 2022
armanbilge
armanbilge approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing it locally!

@armanbilge armanbilge linked an issue Oct 7, 2022 that may be closed by this pull request
Can't use Scala 3 artifact with Scala 2 #4304
Closed
@armanbilge armanbilge merged commit 3656491 into typelevel:main Oct 12, 2022
@armanbilge armanbilge changed the title Recreated compat as a package object in scala_3 to make the artifact usable from scala 2 Make cats.compat a package object for for2_13Use3 compatibility Oct 12, 2022
@TonioGela TonioGela deleted the scala_3_artifact_with_scala_2 branch November 10, 2022 16:03
@armanbilge armanbilge mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Can't use Scala 3 artifact with Scala 2
2 participants
@TonioGela @armanbilge