Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cats.compat a package object for for2_13Use3 compatibility #4315

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Make cats.compat a package object for for2_13Use3 compatibility #4315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b683f6b
Recreated compat as a package object
TonioGela Oct 7, 2022
f7e0d3e
Fixed pull request pointer in mima.sbt
TonioGela Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../scala-3/src/main/scala/cats/compat.scala → .../src/main/scala/cats/compat/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/

package cats.compat
package cats

private[cats] type targetName = scala.annotation.targetName
package object compat {
private[cats] type targetName = scala.annotation.targetName
}
4 changes: 4 additions & 0 deletions mima.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ ThisBuild / mimaBinaryIssueFilters ++= {
exclude[ReversedAbstractMethodProblem]("cats.free.ContravariantCoyoneda.k"),
exclude[DirectAbstractMethodProblem]("cats.free.Coyoneda.k"),
exclude[ReversedAbstractMethodProblem]("cats.free.Coyoneda.k")
) ++ // https://github.com/typelevel/cats/issues/4304
TonioGela marked this conversation as resolved.
Show resolved Hide resolved
Seq(
exclude[MissingClassProblem]("cats.compat.compat$package"),
exclude[MissingClassProblem]("cats.compat.compat$package$")
)
}

Expand Down