-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up warnings and scalac options. #491
Conversation
This removes -deprecation warnings for 2.13 (since there are over 100 of them). It also tries to make it a bit easier to see which options are used for which versions. Finally it removes an unused import.
I'm going to tag you all on these PRs that are primarily build-related. Let me know if anything jumps out at you. |
The previous refactor was still a bit hard to read. This should be easier to understand and is also a bit more compact.
At this point it's probably not worth polishing more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's an interesting way to organise things, too.
I worry this won't work for adding Dotty to the build. After #423 is merged, I predict people will relatively quickly request that Dotty be added as a compiler so there's no backsliding. |
@ashawley I think the strategy will be easily to modify to support dotty. For example: mk(211 to 214(...),
mk(211 to 213)(...),
mk(212 to 300)(...),
mk(214 to 301)(...)) (I think it's very unlikely we'll ever need more than 99 major versions, but we could always pad the 2/3 by 1000 if we needed to.) In the worst case (where the ranges need to be disjoint) we can widen that type to |
Dotty versions are of the scheme "0.17.0-RC1", see https://contributors.scala-lang.org/t/announcing-dotty-0-17-0-rc1/3556 |
Yeah, this will need to be changed for Dotty support. The usual way to do this sort of things is to pattern match on |
This removes -deprecation warnings for 2.13 (since there are over 100
of them). It also tries to make it a bit easier to see which options
are used for which versions. Finally it removes an unused import.
I did this as an isolated PR because it's small and easy to review.