Changes to scalacheck to cross compile with Dotty #423

allanrenucci · 2018-09-14T12:41:07Z

I left out dotty-staging@00f01af on purpose because it is a binary incompatible change. Apart from that scalacheck cross compiles with Dotty

allanrenucci · 2018-09-20T19:21:24Z

@rickynils Are you interested in these changes (or a subset)? Or should I close?

src/main/scala/org/scalacheck/rng/Seed.scala

jvm/src/test/scala/org/scalacheck/GenSpecification.scala

er1c · 2019-04-07T02:21:44Z

@rickynils this would be great! bump!

smarter · 2019-06-29T16:09:18Z

All comments against this PR were addressed 9 months ago, and yet it wasn't merged or closed, what's the hold up ? I've now rebased this PR to fix conflicts, while I was at it I removed one change which is no longer needed (Seed#apply) and added two extra commits to let Dotty compile the code without -language:Scala2. Can I expect it to be merged this time around ?

ashawley · 2019-07-05T15:20:06Z

The Seed.apply change would have technically broken binary compatibility. I can't speak for anyone else, but I didn't finish reviewing the changes for that reason. Since it's now no longer needed, I suppose there's a chance that these fixes for Dotty could be included in a 1.14.1 bug fix release, IMO. With that in mind, I'll try to study the changes again and see if that's the case.

ashawley · 2019-07-08T23:30:19Z

Seems like all of this could be included a 1.14.1 bug fix release to me. I think the change to CmdLineParser is an internal change, so it shouldn't be of any consequence to the user.

src/main/scala/org/scalacheck/Test.scala

smarter · 2019-07-09T15:22:27Z

Are source-incompatible but binary-compatible changes allowed in the 1.14 branch ? One way to obtain the same result as dotty-staging@00f01af would be to simply remove the implicit from implicit def BooleanOperators(b: => Boolean): ExtendedBoolean, but existing code might have to replace import Prop.BooleanOperators by import Prop.propBoolean. If that's not OK, then is there a plan to create a branch for the development of 1.15 ?

ashawley · 2019-07-09T15:56:47Z

As described, that sounds like a change like that would be pretty disruptive to users in a 1.14.1 release.

I wonder if you should create an issue (or issues) to discuss the various Dotty changes you need in ScalaCheck. One assumes there will need to be a lot of coordination and investigation.

smarter · 2019-07-09T16:03:03Z

Besides this PR, the BooleanOperators thing is the only necessary change I'm aware of, we switched the Functional Programming course at EPFL to Dotty last year, the course introduces students to property checking with scalacheck (like the mooc), and those changes were the only one we needed to get everything working.

smarter · 2019-07-30T19:18:21Z

Anything else needed to get this merged ?

For a Boolean b and a prop p, the following is ambiguous in dotty: import Prop._ b ==> p Because Prop contains: implicit def BooleanOperators(b: => Boolean) = new ExtendedBoolean(b) implicit def propBoolean(b: Boolean): Prop = Prop(b) And both ExtendedBoolean and Prop provide a `==>` method, the one in `ExtendedBoolean` just forwards to the one in `Prop`. This is not ambiguous in scalac because `Boolean` wins against `=> Boolean` but it is in dotty (and intentionally so). In general, it seems that all the methods in BooleanOperators are also available on Prop, so BooleanOperators does not serve any purpose and can be deprecated. We can then make it non-implicit in a subsequent release of scalacheck (thus breaking source-compatiblity but not binary-compatiblity) to finally be able to compile it with Dotty (which also requires getting typelevel#423 in).

smarter · 2019-08-07T21:55:07Z

One way to obtain the same result as dotty-staging/scalacheck@00f01af would be to simply remove the implicit from implicit def BooleanOperators(b: => Boolean): ExtendedBoolean

As a first step towards this, I've opened a PR to deprecate BooleanOperators: #498

ashawley · 2019-08-20T10:51:38Z

Unfortunately, we merged #498 first so there's a conflict. Fortunately, the conflict is just a single line. Would you be able to rebase? I also wonder if the new version of MiMa raises anything else.

smarter · 2019-08-20T11:06:37Z

Rebased.

ashawley · 2019-08-20T14:30:55Z

Strange errors from MiMa:

[error]  * method <clinit>()Unit in class java.lang.Object is inaccessible in current version, it must be public.
[error]    filter with: ProblemFilters.exclude[InaccessibleMethodProblem]("java.lang.Object.<clinit>")
[error]  * method <clinit>()Unit in class java.lang.Object is inaccessible in current version, it must be public.
[error]    filter with: ProblemFilters.exclude[InaccessibleMethodProblem]("java.lang.Object.<clinit>")

It happens for Scala 2.11 and 2.12 for both Java and Scala.js 6.0. I'm not sure what to make of this.

SethTisue · 2019-08-20T16:28:18Z

@dwijnand is that something you've seen before?

smarter · 2019-08-20T18:50:38Z

Try restarting the build, travis flakiness manifests itself in weird ways sometimes

ashawley · 2019-08-20T19:02:32Z

Unfortunately, this also happens for me locally, as well.

dwijnand · 2019-08-21T06:56:18Z

@dwijnand is that something you've seen before?

No, that's a new one.

ashawley · 2019-08-21T16:30:14Z

I was able to bisect it to the "Stop using reflective calls" commit. There's a lot of changes in that commit, but the change ofTest.cmdLineParser from a lazy val to an object is probably the issue.

SethTisue · 2019-08-23T18:59:12Z

rebase, now that #521 is merged?

ashawley · 2019-08-23T19:04:59Z

Would @non weigh-in on the binary-compat change? I've been meaning to explore it, but haven't because I predict he may have draw a harder line on this then I had done so previously.

While it's technically possible to make them work with Dotty, it's better to just stop using them since they're slow and also unnecessary here.

Implicitly available functions do not provide implicit views in Dotty, so we need to call them explicitly. (Their long term replacement is documented in http://dotty.epfl.ch/docs/reference/contextual/conversions.html but cannot be used when cross-compiling with Scala 2 currently).

`prettyAny` defines an implicit conversion from `Any` to `Pretty`, this is really dangerous in general. Here the problem is that `Pretty` has a `map` member, so Dotty ends up choosing this conversion when we call `map` on an array. We work around this by first converting the array to a list, but the implicit conversions in this file should really be rethought.

non · 2019-08-28T16:23:16Z

@ashawley I think this is OK. As you say, it's private to ScalaCheck and should be fine.

We may want to do a 1.14.1-RC1 release, just to ensure that this works for people. Assuming there aren't compatibility bugs we can release the same code as 1.14.1. That said, I'm also fine just releasing 1.14.1 and if there are issues moving onto 1.14.2 to fix them (life is short).

non · 2019-08-28T16:32:52Z

I'm gonna go ahead and merge this. @smarter thanks so much for sticking with this!

ashawley · 2019-08-28T16:36:07Z

Ok, just wanted to make sure you had reviewed these changes. Yes, I think doing a follow-up release should there be issues is a good plan.

allanrenucci force-pushed the dotty-upstream branch 2 times, most recently from b71fb5f to 365a116 Compare September 14, 2018 14:32

ashawley reviewed Sep 21, 2018

View reviewed changes

src/main/scala/org/scalacheck/rng/Seed.scala Outdated Show resolved Hide resolved

ashawley reviewed Sep 21, 2018

View reviewed changes

jvm/src/test/scala/org/scalacheck/GenSpecification.scala Outdated Show resolved Hide resolved

allanrenucci force-pushed the dotty-upstream branch from 365a116 to 1e1302c Compare September 21, 2018 09:35

smarter force-pushed the dotty-upstream branch from 1e1302c to d37b6c8 Compare June 29, 2019 16:04

ashawley reviewed Jul 8, 2019

View reviewed changes

src/main/scala/org/scalacheck/Test.scala Outdated Show resolved Hide resolved

ashawley mentioned this pull request Jul 8, 2019

1.14.1 release? #453

Closed

18 tasks

smarter force-pushed the dotty-upstream branch from d37b6c8 to 1194d67 Compare July 9, 2019 15:07

smarter mentioned this pull request Aug 3, 2019

Typelevel migration logistics #490

Closed

ashawley mentioned this pull request Aug 6, 2019

Clean up warnings and scalac options. #491

Merged

smarter mentioned this pull request Aug 7, 2019

Deprecate Prop.BooleanOperators in anticipation of Dotty, add scalafix rewrite rule to rewrite usages #498

Merged

smarter force-pushed the dotty-upstream branch from 1194d67 to b06de52 Compare August 20, 2019 11:06

ashawley mentioned this pull request Aug 23, 2019

Update sbt-mima-plugin to 0.6.0 #521

Merged

allanrenucci and others added 9 commits August 24, 2019 18:15

Add explicit result type for implicit definitions

922329b

Stop using reflective calls

875a207

While it's technically possible to make them work with Dotty, it's better to just stop using them since they're slow and also unnecessary here.

Case class unapply does not return a Tuple in Dotty

dde8486

Lazy values may not override non-lazy values in Dotty

283aaf9

Insert empty argument lists. Dotty removes auto-application

3f6e167

Please Mima: modified classes and methods were private

18cc524

Work around mima bug

7bb0613

smarter force-pushed the dotty-upstream branch from 7b95f2e to 7bb0613 Compare August 24, 2019 16:15

smarter mentioned this pull request Aug 28, 2019

Plan for 1.14.1 and beyond #500

Closed

non merged commit ab15a9f into typelevel:master Aug 28, 2019

ashawley mentioned this pull request Dec 10, 2019

org.scalacheck.SeedSpecification failed in the community build scala/scala3#7627

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to scalacheck to cross compile with Dotty #423

Changes to scalacheck to cross compile with Dotty #423

allanrenucci commented Sep 14, 2018

allanrenucci commented Sep 20, 2018

er1c commented Apr 7, 2019

smarter commented Jun 29, 2019

ashawley commented Jul 5, 2019

ashawley commented Jul 8, 2019

smarter commented Jul 9, 2019

ashawley commented Jul 9, 2019

smarter commented Jul 9, 2019

smarter commented Jul 30, 2019

smarter commented Aug 7, 2019

ashawley commented Aug 20, 2019

smarter commented Aug 20, 2019

ashawley commented Aug 20, 2019

SethTisue commented Aug 20, 2019

smarter commented Aug 20, 2019 •

edited

Loading

ashawley commented Aug 20, 2019

dwijnand commented Aug 21, 2019 •

edited

Loading

ashawley commented Aug 21, 2019

SethTisue commented Aug 23, 2019

ashawley commented Aug 23, 2019

non commented Aug 28, 2019 •

edited

Loading

non commented Aug 28, 2019

ashawley commented Aug 28, 2019

Changes to scalacheck to cross compile with Dotty #423

Changes to scalacheck to cross compile with Dotty #423

Conversation

allanrenucci commented Sep 14, 2018

allanrenucci commented Sep 20, 2018

er1c commented Apr 7, 2019

smarter commented Jun 29, 2019

ashawley commented Jul 5, 2019

ashawley commented Jul 8, 2019

smarter commented Jul 9, 2019

ashawley commented Jul 9, 2019

smarter commented Jul 9, 2019

smarter commented Jul 30, 2019

smarter commented Aug 7, 2019

ashawley commented Aug 20, 2019

smarter commented Aug 20, 2019

ashawley commented Aug 20, 2019

SethTisue commented Aug 20, 2019

smarter commented Aug 20, 2019 • edited Loading

ashawley commented Aug 20, 2019

dwijnand commented Aug 21, 2019 • edited Loading

ashawley commented Aug 21, 2019

SethTisue commented Aug 23, 2019

ashawley commented Aug 23, 2019

non commented Aug 28, 2019 • edited Loading

non commented Aug 28, 2019

ashawley commented Aug 28, 2019

smarter commented Aug 20, 2019 •

edited

Loading

dwijnand commented Aug 21, 2019 •

edited

Loading

non commented Aug 28, 2019 •

edited

Loading