No local icon in Firefox at about:addons after 170% zoom

[leoheitmannruiz]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

As in #939

128 is not specified at https://github.com/gorhill/uBlock/blob/master/platform/firefox/manifest.json#L97, so after a certain zoom level, there's no local icon Firefox can display and https://addons.mozilla.org/user-media/addon_icons/607/607454-128.png?modified=mcrushed is fetched.

I can image 128 being the final "missing" size. At least, it's the only one Firefox fetches on my 2022 MacBook Air.

Also, the image being fetched is not an SVG, which is kinda sad :(

A specific URL where the issue occurs.

about:addons

Steps to Reproduce

1. Go to about:addons
2. Zoom in (a bunch, perhaps)
3. Open the uBO icon in new tab and see it's addons.mozilla.org

Expected behavior

Have the icon be an SVG for all zoom levels and Firefox not connecting to addons.mozilla.org for the icon.

Actual behavior

Icon is fetched from addons.mozilla.org.

uBO version

1.58.0

Browser name and version

LibreWolf (127.0.2-2)

Operating System and version

macOS Sonoma 14.5

[gwarser]

I see SVG in Firefox. Fetched directly from xpi package. Ask LibreWolf why they don't use SVG.

[gwarser]

I cannot reproduce your issue on Win11 with uBO 1.58.0:

Also, no issue in Manjaro with Firefox Nightly and uBO dev build.

[leoheitmannruiz]

Could this be related to screen pixel density stuff?

Just tested with Firefox (I turned off internet connection):

[gwarser]

@leoheitmannruiz yes. With layout.css.devPixelsPerPx set to 2, I can reproduce when zoomed to 170%

[leoheitmannruiz]

I just added the size 128 icon in a local version and that fixed it.