uBO icon in Manage Your Extensions disappears in the offline mode or when network connectivity is not available

[ediowar]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

[When you enter the offline mode, the uBO icon in Manage Your Extensions disappears.]

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

Expected behavior:

[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

• uBlock Origin version: 1.25.0
• Browser Name and version: Firefox 73.0.1 (64-bit)
• Operating System and version: Ubuntu 16.04.6 LTS

[uBlock-user]

Offline mode ? No steps to reproduce ?

[uBlock-user]

I see what you mean. The uBO icon is hosted at https://addons.cdn.mozilla.net/user-media/addon_icons/607/607454-32.png, but Firefox is not caching the extension icon when it downloads it to display in Manage Your Extensions pane. This happens for all extensions if the pane is refreshed in offline mode or if the internet connection is not available.

This is a Firefox issue.

[uBlock-user]

@agi90 Doesn't Firefox cache the extensions icons when extensions are installed for the first time ?

[gwarser]

It's because 32px icon is not specified in manifest. It seems adding this is enough:

  "icons": {
    "32": "img/ublock.svg",
    "64": "img/ublock.svg",

At least in debug mode. I'm also not sure "64" version is needed.

---

ClearURLs extension works fine, and have this in manifest:

"icons": {
        "16": "img/clearurls_16x16.png",
        "19": "img/clearurls_19x19.png",
        "20": "img/clearurls_20x20.png",
        "24": "img/clearurls_24x24.png",
        "30": "img/clearurls_30x30.png",
        "32": "img/clearurls_32x32.png",
        "38": "img/clearurls_38x38.png",
        "48": "img/clearurls_48x48.png",
        "64": "img/clearurls_64x64.png",
        "96": "img/clearurls_96x96.png",
        "128": "img/clearurls_128x128.png"
    },

---

Must be something with this new HTML about:addons interface, because some icons are loaded from cache just fine. Anyway, it will be better to load them from extension package.

[uBlock-user]

@gwarser Does this fix uMatrix too ?

[gorhill]

Though here it says:

You should supply at least a main extension icon, ideally 48x48 px in size. This is the default icon that will be used in the Add-ons Manager.