UPSE-285: address Gradle file issue which seems more prominent when u… #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
requested changes
Jan 6, 2023
There was a problem hiding this comment.
Thanks @groybal!
Have you had a chance to check out the CI failure? It seems to point to missing properties on some of the variables.
ChristianMurphy
approved these changes
Jan 6, 2023
groybal
force-pushed
the
UPSE-285
branch
2 times, most recently
from
689b9a7 to
ca4f9ea
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing Java 11
Checklist
Description of change
Updated how files are used in Gradle scripts in order to avoid issue where Gradle uses current-working-directory (CWD) that is not the project directory, and problems can arise when files are then not found. This issue was found when testing with Java 11, and the issue caused portal.home to be set to the wrong directory.
See: https://docs.gradle.org/current/userguide/working_with_files.html#sec:single_file_paths