Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSE-362: updates for CAS Webapp to run w/ Java 11 #616

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

groybal
Copy link
Contributor

@groybal groybal commented Jan 9, 2023

Checklist
Description of change

The CAS webapp was failing to startup when running Tomcat with Java 11.
Issue is that it needs newer versions of AspectJ jars.
Updated overlay build.gradle to replace older jars with newer ones that work with Java 11.

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Jan 9, 2023

🤔 not quite sure what to make of the CI error:

Execution failed for task ':tomcatClearLogs'.
> java.io.IOException: Unable to delete file 'D:\a\uPortal-start\uPortal-start\.gradle\tomcat\logs\catalina.2023-01-09.log'

https://github.com/uPortal-Project/uPortal-start/actions/runs/3873631662/jobs/6603882581#step:8:228

It doesn't feel like it's related to these changes 🤔
Maybe it's related to #613 ?

@groybal
Copy link
Contributor Author

groybal commented Jan 10, 2023

thinking not quite sure what to make of the CI error:

Execution failed for task ':tomcatClearLogs'.
> java.io.IOException: Unable to delete file 'D:\a\uPortal-start\uPortal-start\.gradle\tomcat\logs\catalina.2023-01-09.log'

https://github.com/uPortal-Project/uPortal-start/actions/runs/3873631662/jobs/6603882581#step:8:228

It doesn't feel like it's related to these changes thinking Maybe it's related to #613 ?

Once #613 gets merged, I'll rebase and hopefully we'll find out it was just a temporary issue.

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Jan 11, 2023

@groybal
Copy link
Contributor Author

groybal commented Jan 11, 2023

thinking even after it's been related same issue https://github.com/uPortal-Project/uPortal-start/actions/runs/3897171369/jobs/6654560812#step:8:221

Very odd ...I don't see how the simple change in this PR would cause this issue, but we've seen now it is consistent (so far). Not sure how to proceed.

@loulou2u loulou2u requested review from loulou2u and bjagg January 18, 2023 22:17
Copy link
Contributor

@loulou2u loulou2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks were successful!... all looks good to me! 💯

@loulou2u loulou2u marked this pull request as ready for review January 18, 2023 22:33
@loulou2u loulou2u merged commit 49f4133 into uPortal-Project:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants