-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check mount paths exist #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better to change the check_path_exists
function to take a list of paths and then check all entries in the list and return a list of missing paths all in one shot. Otherwise you'll have to do multiple runs of QuaC to catch all the missing paths with the current setup.
The extra benefit from this will also be that you can reduce the call of the function in read_workflow_config
to a single call to check all the mount paths and files in one shot.
@wilkb777 Good point. I have now refactored to check mount paths all at once. Note that earlier I used to verify if the datasets specified in the workflow config file existed, but now the scope is restricted to just check the directories that will be mounted to singularity. That is, pipeline may still fail if the specified filepath doesn't exist under those directories. I think this is okay though. Additionally, I have now refactored to resolve the dirpaths in the workflow config file; so no more partial paths. This should also take symlinks. [Updated MR description to reflect this change]. Checked system testing after these changes, and it was successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, that's a great change along with the path existence assertion. LGTM!
Pull request
Please fill in the checklist below and comment as needed.
configs/multiqc_config_template.jinja2
and scriptsrc/quac_watch/create_mutliqc_configs.py
as necessary? No.Changelog.md
file with change logs in recommended format?Anything else reviewer should know?