Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring master branch up to date #81

Merged
merged 157 commits into from
Jun 30, 2023
Merged

Bring master branch up to date #81

merged 157 commits into from
Jun 30, 2023

Conversation

ManavalanG
Copy link
Member

@ManavalanG ManavalanG commented Jun 30, 2023

Pull request

This PR will merge current version of joss_manuscript to the master branch to bring it up to date, and then we will cut a new release. Note that joss_manuscript branch will not be deleted and it will continue to serve as the branch to be used for JOSS reviews.

This PR includes several PRs as follows:

Changelog corresponding to this PR is listed below:

2023-06-22 Manavalan Gajapathy

  • Refactors CLI script to accounting for user's environment specific slurm args requirements when submitting job to
    slurm (CLI script not accounting for user's environment specific slurm args requirements #76)
  • Removes CLI option --rerun_failed and instead configures it via snakemake-slurm profile
    (src/slurm/slurm_profile/config.yaml)
  • Removes --subtasks_slurm option and --snakemake_slurm as they were redundant
  • Checks if tool dependencies are available in user environment.
  • Adds time resource to configs/snakemake_cluster_config.json
  • Removes PR trigger from system testing github actions.
  • Tests if singularity is working as expected in user machine

2023-05-31 Manavalan Gajapathy

  • Adds system testing as github actions workflow

2023-05-18 Manavalan Gajapathy

  • Constructs snakemake's sbatch command using args and values from cluster config file supplied via
    --cluster_config.
  • Updates doc to include cluster config as a requirement

2023-05-09 Manavalan Gajapathy

  • Adds a verification step in the CLI wrapper script to check if the file/dirpaths to be mounted to singularity already
    exist as expected (Verify singularity mount paths exist #71)
  • Resolves dirpaths of datasets in the workflow config file to obtain their full path

2023-04-10 Manavalan Gajapathy

2023-04-04 Manavalan Gajapathy

  • Retires use of cheaha-specific env variable $USER_SCRATCH
  • Auto-creates user-provided dir structures for --outdir, --tmp_dir, and --log_dir

Please fill in the checklist below and comment as needed.

  • Was code modified? Briefly describe. Yes, but changes were already reviewed as part of earlier PRs
  • Was documentation modified? Briefly describe. Yes, but changes were already reviewed as part of earlier PRs
  • Is this a bug-fix? Briefly describe. Yes, but changes were already reviewed as part of earlier PRs
  • Is this a feature addition? Briefly describe. Yes, but changes were already reviewed as part of earlier PRs
  • Did you modify QuaC-Watch config file? If so, did you modify multiqc template
    configs/multiqc_config_template.jinja2 and script src/quac_watch/create_mutliqc_configs.py as necessary? No
  • Did you perform system-level testing manually as described in master readme doc? Did it pass completely? If not why? Yes
  • Updated Changelog.md file with change logs in recommended format?

Anything else reviewer should know?

@ManavalanG ManavalanG requested a review from wilkb777 June 30, 2023 20:22
Copy link
Member

@wilkb777 wilkb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManavalanG ManavalanG merged commit 8536fe7 into master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants