-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring master branch up to date #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autocreate user-provided dirpath if they don't exist
Co-authored-by: Brandon M Wilk <wilkb777@gmail.com>
Co-authored-by: Brandon M Wilk <wilkb777@gmail.com>
Co-authored-by: Brandon M Wilk <wilkb777@gmail.com>
Co-authored-by: Brandon M Wilk <wilkb777@gmail.com>
Co-authored-by: Brandon M Wilk <wilkb777@gmail.com>
Refactors to account for user's environment-specific SLURM setup
wilkb777
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This PR will merge current version of
joss_manuscript
to themaster
branch to bring it up to date, and then we will cut a new release. Note thatjoss_manuscript
branch will not be deleted and it will continue to serve as the branch to be used for JOSS reviews.This PR includes several PRs as follows:
Changelog corresponding to this PR is listed below:
2023-06-22 Manavalan Gajapathy
slurm (CLI script not accounting for user's environment specific slurm args requirements #76)
--rerun_failed
and instead configures it via snakemake-slurm profile(
src/slurm/slurm_profile/config.yaml
)--subtasks_slurm option
and--snakemake_slurm
as they were redundanttime
resource toconfigs/snakemake_cluster_config.json
2023-05-31 Manavalan Gajapathy
2023-05-18 Manavalan Gajapathy
sbatch
command using args and values from cluster config file supplied via--cluster_config
.2023-05-09 Manavalan Gajapathy
exist as expected (Verify singularity mount paths exist #71)
2023-04-10 Manavalan Gajapathy
using singularity containers! (Removing use of conda env for tasks within snakemake pipeline #69)
2023-04-04 Manavalan Gajapathy
--outdir
,--tmp_dir
, and--log_dir
Please fill in the checklist below and comment as needed.
configs/multiqc_config_template.jinja2
and scriptsrc/quac_watch/create_mutliqc_configs.py
as necessary? NoChangelog.md
file with change logs in recommended format?Anything else reviewer should know?