Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White strip on top of the NTP when bottom toolbar is enabled #180

Closed
5 tasks done
Ramvish29 opened this issue Aug 12, 2023 · 9 comments
Closed
5 tasks done

White strip on top of the NTP when bottom toolbar is enabled #180

Ramvish29 opened this issue Aug 12, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@Ramvish29
Copy link

Ramvish29 commented Aug 12, 2023

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have read the FAQs.
  • I have updated Cromite to the latest version. The bug is reproducible on this latest version.
  • This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

No

Cromite version

116.0.5845.82

Device architecture

arm64-v8a

Android version

13

Device model

Moto edge 30

Changed flags

No flag changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

When bottom toolbar is enabled from setting/flag there is a white strip visible on top of the New tab page. (Dark mode enabled)

Steps to reproduce the bug

Activate bottom tool bar and it is visible

Expected behavior

White strip shouldn't be there

Screenshots

Details

Screenshot_20230812-182515

@Ramvish29 Ramvish29 reopened this Aug 12, 2023
@uazo uazo added the need triage I will look into it, I promise! label Aug 15, 2023
@uazo
Copy link
Owner

uazo commented Aug 23, 2023

I saw that you enabled list mode as a tab switcher, and I seem to remember that it is activated if a non-performing device is detected.
Or is this something you did on purpose?

@uazo uazo added the awaiting info Further information is requested label Aug 23, 2023
@Ramvish29
Copy link
Author

Ramvish29 commented Aug 23, 2023

I saw that you enabled list mode as a tab switcher, and I seem to remember that it is activated if a non-performing device is detected. Or is this something you did on purpose?

So i just reinstalled the cromite to see if i enabled the list mode accidentally via flag and the list mode is enabled even after a reinstall...so the list view is default...also i have moto edge 30 with Snapdragon 778g so its fairly good device

@uazo uazo removed the awaiting info Further information is requested label Aug 23, 2023
@uazo
Copy link
Owner

uazo commented Aug 23, 2023

ok thanks.
Since I would like to enable list mode, I was wondering if there were any flags already available.
regarding your problem, I will check.

@uazo
Copy link
Owner

uazo commented Aug 26, 2023

to force list mode shouldUseListMode
it would be sufficient to add the setting

@uazo uazo added enhancement New feature or request and removed need triage I will look into it, I promise! labels Aug 26, 2023
@Ramvish29
Copy link
Author

Ramvish29 commented Aug 26, 2023

ok thanks. Since I would like to enable list mode, I was wondering if there were any flags already available. regarding your problem, I will check.

Just found out that list mode can be enabled from settings-accessbility-simplified view for open tabs
I disabled this setting and the white strip is gone

@uazo uazo added bug Something isn't working and removed enhancement New feature or request labels Aug 26, 2023
@uazo
Copy link
Owner

uazo commented Aug 26, 2023

settings-accessbility-simplified view for open tabs

thanks! that makes it easier to fix it

@uazo
Copy link
Owner

uazo commented Dec 16, 2023

@Ramvish29 can you try the latest version?

@Ramvish29
Copy link
Author

Ramvish29 commented Dec 16, 2023

@Ramvish29 can you try the latest version?

I am already on the latest version everything is working fine what do you want me to check? Using default except move top toolbar to bottom flag

@Ramvish29
Copy link
Author

@Ramvish29 can you try the latest version?

Just found out i wasn't on the latest version (why didn't updater pushed it though)
And after update toolbar went to top but after turning back on from settings it is now on the bottom.

@uazo uazo closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants