Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Add the possibility of quickly inserting new flags #403

Open
uazo opened this issue Oct 14, 2023 · 2 comments
Open

[Infra] Add the possibility of quickly inserting new flags #403

uazo opened this issue Oct 14, 2023 · 2 comments
Labels
task These are things I tell myself I should do working on it working on it

Comments

@uazo
Copy link
Owner

uazo commented Oct 14, 2023 •
edited
Loading

I need a way to easily and quickly insert new flags with their respective ui's and with an eye on the localization that I will set up sooner or later. I often and often do without it because I am lazy, but it is a mistake, there must be an option to disable a feature in case of bugs.

The idea:

  • Reuse the logic I developed for site settings for flags as well, modifying all the patches (of which there are many) that add specific flags in cromite
  • Modify the ui by inserting a flag section in settings, both in android and in windows: here is the question of whether it makes sense to do only one in javascript, so as to have the same code
  • while I'm at it, modify chromium's flag activation/deactivation logic, taking advantage of what brave is doing (which I haven't analysed yet, but looks good to me).

the advantage is also a simplification of rebase and especially the elimination of all those line changes in patches during automatic rebase.

blocking:

add

  • flag for kEnablePortBoundCookies
  • flag for ViewportSegmentsEnabled
  • flag for kMigrateSessionsOnNetworkChangeV2
@uazo uazo added enhancement New feature or request help wanted Extra attention is needed / I am not capable of it / I would need labels Oct 14, 2023
@Universalizer

This comment was marked as off-topic.

Sign in to view
This was referenced Oct 21, 2023
Closed
Closed
@uazo uazo added task These are things I tell myself I should do and removed enhancement New feature or request labels Oct 22, 2023
@uazo uazo mentioned this issue Nov 1, 2023
Open
@uazo uazo mentioned this issue Nov 18, 2023
Merged
@uazo uazo mentioned this issue Nov 30, 2023
Closed
@uazo uazo removed the help wanted Extra attention is needed / I am not capable of it / I would need label Nov 30, 2023
uazo added a commit that referenced this issue Dec 13, 2023
@uazo
#403 added support for checking and setting flags (even without cachi…
deaac61 
…ng) from java

and moved the incorrect code between patches
uazo added a commit that referenced this issue Dec 13, 2023
@uazo
#403 added the possibility of defining the flag to be modified direct…
65f68be 
…ly from the xml.

removed the need to specify, for cromite flags, permission for use by java
introduced placeholder support also for the android_chrome_strings_grd target
uazo added a commit that referenced this issue Dec 13, 2023
@uazo
#580 Use list mode for tab switcher
e7e9329 
test of #403
related #538 #180
@uazo uazo mentioned this issue Dec 14, 2023
Closed
@uazo uazo added the working on it working on it label Dec 24, 2023
@uazo
Copy link
Owner Author

uazo commented Oct 10, 2024

I also need to manage changes to runtime_enabled_features.json5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task These are things I tell myself I should do working on it working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uazo @Universalizer