Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Denied status of an allocation is the only status that sends a signal #474

Closed
knikolla opened this issue Dec 12, 2022 · 0 comments
Closed

The Denied status of an allocation is the only status that sends a signal #474

knikolla opened this issue Dec 12, 2022 · 0 comments
Assignees
@rg663
Labels
bug Something isn't working

Comments

@knikolla
Copy link
Contributor

There is an allocation_disable signal, but it is only sent for the Denied status.

coldfront/coldfront/core/allocation/views.py

Line 251 in 68ba4b6

if new_status == 'Denied':

It should at least also be sent for the Revoked status, and perhaps some other relevant status.

The motivation is that it does seem a bit weird to "deny" an allocation that already exists, rather than "revoking" it.
@dsajdak dsajdak added the bug Something isn't working label Jan 5, 2023
@rg663 rg663 mentioned this issue Jan 6, 2023
Closed
@aebruno aebruno added this to ColdFront Feb 8, 2023
@aebruno aebruno moved this to In Progress in ColdFront Feb 8, 2023
@rg663 rg663 mentioned this issue Feb 9, 2023
Merged
@aebruno aebruno closed this as completed Feb 10, 2023
@aebruno aebruno moved this from In Progress to Completed in ColdFront Feb 10, 2023
knikolla added a commit to knikolla/coldfront-nerc that referenced this issue Feb 16, 2023
@knikolla
Update ColdFront version to v1.1.4
2ca5c90 
Note:
   Requires running database migrations since it includes new schema.

Among other things, this fixes nerc-project#76, since it corrects the mismatch
between our version of the email templates and coldfront code.

It also includes
- Only Denied sending a signal, now Revoked also does.
ubccr/coldfront#474

- Implements project attributes, which can be really useful.
ubccr/coldfront#466

- Updates the ColdFront logo
ubccr/coldfront#431

Closes nerc-project#76
@knikolla knikolla mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rg663 rg663

Labels
bug Something isn't working
Projects
ColdFront
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aebruno @knikolla @dsajdak @rg663