Signal fixed on changing allocation statuses #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aebruno
requested changes
Feb 9, 2023
coldfront/core/allocation/views.py
Outdated
| @@ -232,22 +232,25 @@ def post(self, request, *args, **kwargs): | |||
| if action != 'auto-approve': | |||
| messages.success(request, 'Allocation Activated!') | |||
|
|
|||
| elif old_status != allocation_obj.status.name in ['Denied', 'New']: | |||
| elif old_status != allocation_obj.status in ['Denied', 'New', 'Revoked']: | |||
There was a problem hiding this comment.
This needs to be elif old_status != allocation_obj.status.name in ['Denied', 'New', 'Revoked']:
coldfront/core/allocation/views.py
Outdated
| send_allocation_customer_email(allocation_obj, 'Allocation Denied', 'email/allocation_denied.txt', domain_url=get_domain_url(self.request)) | ||
| messages.success(request, 'Allocation Denied!') | ||
| elif allocation_obj.status == 'Revoked': |
There was a problem hiding this comment.
This should be elif allocation_obj.status.name == 'Revoked':
changed references to allocation_obj.status to allocation_obj.status.name
aebruno
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #474 — Now, allocations that have been given a revoked status display a similar behavior to an allocation that has been marked as denied, sending an email to the user and signaling that the allocation should be disabled. Newlines are also added to email templates to enhance readability.