Remove script tag #113
Merged
Remove script tag #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file included by the removed script tag is part of the App Kernels module.
6 tasks
plessbd
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file included by the removed script tag is part of the App Kernels
module.
Description
Removes a script tag from the internal dashboard index HTML file.
See ubccr/xdmod-appkernels#19
Motivation and Context
The removed tag should be part of the App Kernels module.
Tests performed
Installed with and without App Kernels module. Confirmed that the tag was present only when the App Kernels module is installed and that no JavaScript errors were produced.
Types of changes
Checklist: