Metric Explorer: Fixed errors not displaying if help graphic active #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsperhac
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Metric Explorer has a help graphic that is active when there is no data to display (for example, when a new chart has been created). If a user chooses an invalid configuration while this graphic is active, the error message will still be written on the chart, but the chart is hidden by the graphic. This pull request ensures that the chart will not be hidden if an error message is written on it.
Motivation and Context
It is important to inform users why their settings are invalid and not just appear to do nothing.
Tests performed
Ran automated UI tests and verified that they ran the same as before. Performed manual testing in Chrome and Firefox to ensure other Metric Explorer functionality was not impacted.
Types of changes
Checklist:
I have added tests to cover my changes.