Change acl-config backup tables detected error message
#1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
added
enhancement
plessbd
reviewed
Nov 14, 2019
| @@ -427,7 +427,8 @@ SQL; | |||
| $log->err('Backup tables detected! '); | |||
| $log->err('Unable to continue!'); | |||
| $log->err('This may indicate a failed previous run.'); | |||
| $log->err('Please see the XDMoD Troubleshooting documentation to resolve.'); | |||
| $log->err('Run "acl-config --recover" to recover using backup tables.'); | |||
| $log->err('See https://open.xdmod.org/9.0/faq.html#why-do-i-see-backup-tables-detected-when-running-the-acl-config-script for more information.'); | |||
There was a problem hiding this comment.
is there any way to have this link without the version number in it? from my very basic testing i couldnt get it to redirect with the anchor but didnt know if you looked into it
I dont like the idea of having to update this everytime. but i also dont like my suggestion very much either...
Suggested change
| $log->err('See https://open.xdmod.org/9.0/faq.html#why-do-i-see-backup-tables-detected-when-running-the-acl-config-script for more information.'); | |
| $log->err('See the XDMoD FAQ (https://open.xdmod.org/faq.html)'); | |
| $log->err('section: Why do I see “Backup tables detected!” when running the acl-config script?'); | |
| $log->err('for more information.'); |
There was a problem hiding this comment.
I couldn't find a URL that would redirect properly either. I'd prefer to not include the version number, but unless we can get the redirect working this is good enough for me.
plessbd
approved these changes
Nov 14, 2019
ryanrath
approved these changes
Nov 14, 2019
jtpalmer
changed the title
acl-config backup tables detected error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
acl-configerror message to add additional details.Motivation and Context
Specifies the command to run so you don't need to look it up and provides a URL so you don't need to search for it.
Tests performed
Types of changes
Checklist: