Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change acl-config backup tables detected error message #1164

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Change acl-config backup tables detected error message #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/acl-config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,8 @@ SQL;
$log->err('Backup tables detected! ');
$log->err('Unable to continue!');
$log->err('This may indicate a failed previous run.');
$log->err('Please see the XDMoD Troubleshooting documentation to resolve.');
$log->err('Run "acl-config --recover" to recover using backup tables.');
$log->err('See https://open.xdmod.org/9.0/faq.html#why-do-i-see-backup-tables-detected-when-running-the-acl-config-script for more information.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to have this link without the version number in it? from my very basic testing i couldnt get it to redirect with the anchor but didnt know if you looked into it

I dont like the idea of having to update this everytime. but i also dont like my suggestion very much either...

Suggested change
$log->err('See https://open.xdmod.org/9.0/faq.html#why-do-i-see-backup-tables-detected-when-running-the-acl-config-script for more information.');
$log->err('See the XDMoD FAQ (https://open.xdmod.org/faq.html)');
$log->err('section: Why do I see “Backup tables detected!” when running the acl-config script?');
$log->err('for more information.');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a URL that would redirect properly either. I'd prefer to not include the version number, but unless we can get the redirect working this is good enough for me.

exit(1);
} elseif (!$backupTablesExist) {
if ($recover) {
Expand Down