Disallow Updating of Federated User's Passwords #444
Conversation
classes/XDUser.php
Outdated
| @@ -544,9 +544,11 @@ public static function getUserByID($uid, &$targetInstance = NULL) | |||
|
|
|||
| public function setPassword($raw_password) | |||
| { | |||
| if ($this->getUserType() === FEDERATED_USER_TYPE){ | |||
| throw new Exception("Permission Denied. Only local accounts may have their passwords modified."); | |||
There was a problem hiding this comment.
This message does not imply what the condition is checking.
"Federated users are not allow to have their passwords modified."
would probably be better :)
| listeners: { | ||
| blur: XDMoD.utils.trimOnBlur, | ||
| focus: removeFieldHighlight, | ||
| invalid: function (thisField/* , msg */) { |
There was a problem hiding this comment.
Either remove the commented code or pass the parameter since it is in the function spec.
There was a problem hiding this comment.
Leave function arguments:
ubccr/xdmod-qa@ff9ae2e
| msgTarget: 'under', | ||
| submitValue: false, | ||
|
|
||
| validator: function (/* value */) { |
There was a problem hiding this comment.
Either remove the commented code or pass the parameter since it is in the function spec.
| var decodedSuccess; | ||
| if (success) { | ||
| data = CCR.safelyDecodeJSONResponse(response); | ||
| decodedSuccess = CCR.checkDecodedJSONResponseSuccess(data); |
There was a problem hiding this comment.
Nitpicky, but shouldn't this be named "decodedSuccessResponse"?
|
After talking with smgallo, we have decided to update the linting rules (ubccr/xdmod-qa@ff9ae2e) to allow unused function arguments. These should stay in |
classes/XDUser.php
Outdated
| @@ -544,9 +545,11 @@ public static function getUserByID($uid, &$targetInstance = NULL) | |||
|
|
|||
| public function setPassword($raw_password) | |||
| { | |||
| if ($this->getUserType() === FEDERATED_USER_TYPE){ | |||
There was a problem hiding this comment.
Please add a space between closing parens and left brace.
Description
As above.
Old:
New:
Motivation and Context
Ben's comments on testing.
Tests performed
Yeah.
Types of changes
Checklist: