Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Updating of Federated User's Passwords #444

Merged
merged 9 commits into from
Feb 26, 2018
Merged

Disallow Updating of Federated User's Passwords #444

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a9919d5
Cleanup in Aisle 3.
chakrabortyr Feb 23, 2018
7fc65fe
Disallow editing passwords for federated users.
chakrabortyr Feb 23, 2018
fa7990b
More verbose error.
chakrabortyr Feb 23, 2018
3bcfa62
Merge remote-tracking branch 'upstream/xdmod7.5' into RC_DisableFeder…
chakrabortyr Feb 23, 2018
e94cffc
Reformatting.
chakrabortyr Feb 23, 2018
4f89c1c
Removed commented code, refactoring var names
chakrabortyr Feb 26, 2018
a5d5a35
Put back in commented out vars(-_-). Sensible variable names.
chakrabortyr Feb 26, 2018
7f268f5
Updatd Exception to use the new DataWarehouse ones.
chakrabortyr Feb 26, 2018
fa8cc26
Added a space.
chakrabortyr Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion classes/XDUser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,9 +544,11 @@ public static function getUserByID($uid, &$targetInstance = NULL)

public function setPassword($raw_password)
{
if ($this->getUserType() === FEDERATED_USER_TYPE){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space between closing parens and left brace.

throw new Exception("Permission Denied. Only local accounts may have their passwords modified.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message does not imply what the condition is checking.

"Federated users are not allow to have their passwords modified."

would probably be better :)

}

return $this->_password = $raw_password;

}//setPassword

// ---------------------------
Expand Down
Loading