Skip to content

Commit

Permalink
made Guava dependence explicit (#120)
Browse files Browse the repository at this point in the history
See #119. Error Prone does not expose its packaged Guava on Bazel. NullAway does indeed rely on Guava, and this will make it work better out of the box on Bazel. Eventually, we can think about shading or getting rid of this dependence, but this is a first step.
  • Loading branch information
msridhar authored Feb 4, 2018
1 parent 82d4e0f commit caeb60c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def build = [
checkerDataflow : ["org.checkerframework:dataflow:${versions.checkerFramework}",
"org.checkerframework:javacutil:${versions.checkerFrameworkNAFork}"],
gradleErrorPronePlugin : "net.ltgt.gradle:gradle-errorprone-plugin:0.0.8",
guava : "com.google.guava:guava:21.0",
guava : "com.google.guava:guava:22.0",
jsr305Annotations : "com.google.code.findbugs:jsr305:3.0.2",

// android stuff
Expand Down
1 change: 1 addition & 0 deletions nullaway/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ dependencies {

compileOnly deps.build.errorProneCheckApi
compile deps.build.checkerDataflow
shadow deps.build.guava

errorprone deps.build.errorProneCore

Expand Down

0 comments on commit caeb60c

Please sign in to comment.