Make Guava dependence explicit #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kageiit
approved these changes
Feb 4, 2018
| @@ -34,7 +34,7 @@ def build = [ | |||
| checkerDataflow : ["org.checkerframework:dataflow:${versions.checkerFramework}", | |||
| "org.checkerframework:javacutil:${versions.checkerFrameworkNAFork}"], | |||
| gradleErrorPronePlugin : "net.ltgt.gradle:gradle-errorprone-plugin:0.0.8", | |||
| guava : "com.google.guava:guava:21.0", | |||
| guava : "com.google.guava:guava:22.0", | |||
There was a problem hiding this comment.
I'm trying to minimize potential incompatibility with other annotation processors. If we decide to shade Guava I'll bump higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #119. Error Prone does not expose its packaged Guava on Bazel. NullAway does indeed rely on Guava, and this will make it work better out of the box on Bazel. Eventually, we can think about shading or getting rid of this dependence, but this is a first step.