-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coroutines 1.7.3 #609
Conversation
@@ -63,6 +63,7 @@ class WorkerBinderTest(private val adaptFromRibCoroutineWorker: Boolean) { | |||
@Before | |||
fun setUp() { | |||
RibEvents.enableRibActionEmissions() | |||
RibCoroutinesConfig.deprecatedWorkerDispatcher = ribCoroutinesRule.ribDispatchers.Unconfined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required to handle previously failing test.
Exception in thread "Test worker @coroutine#2" expected to be true at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:156) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:154) at com.uber.rib.core.WorkerBinderTestKt$Worker$1.onStart(WorkerBinderTest.kt:259) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:316) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:310) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$lambda-6$$inlined$collectWhile$1.emit(Limit.kt:143) at kotlinx.coroutines.flow.SharedFlowImpl.collect$suspendImpl(SharedFlow.kt:383) at kotlinx.coroutines.flow.SharedFlowImpl.collect(SharedFlow.kt) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:124) at kotlinx.coroutines.flow.FlowKt__EmittersKt$onCompletion$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:114) at com.uber.rib.core.WorkerBinderKt$bind$job$1.invokeSuspend(WorkerBinder.kt:310) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:367) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:30) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable$default(Cancellable.kt:25) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:110) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56) at kotlinx.coroutines.BuildersKt.launch(Unknown Source) at com.uber.rib.core.WorkerBinderKt.bind(WorkerBinder.kt:293) at com.uber.rib.core.WorkerBinderKt.access$bind(WorkerBinder.kt:1) at com.uber.rib.core.WorkerBinder.bind(WorkerBinder.kt:69) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invokeSuspend(WorkerBinderTest.kt:160) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invokeSuspend(TestBuilders.kt:212) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.intrinsics.UndispatchedKt.startCoroutineUndispatched(Undispatched.kt:55) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:112) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTestCoroutine(TestBuilders.kt:211) at kotlinx.coroutines.test.TestBuildersKt.runTestCoroutine(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invokeSuspend(TestBuilders.kt:167) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersJvmKt$createTestResult$1.invokeSuspend(TestBuildersJvm.kt:13) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284) at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59) at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38) at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source) at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:12) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:166) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:154) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest$default(TestBuilders.kt:147) at kotlinx.coroutines.test.TestBuildersKt.runTest$default(Unknown Source) at com.uber.rib.core.WorkerBinderTest.bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly(WorkerBinderTest.kt:151) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [CoroutineId(2), "coroutine#2":StandaloneCoroutine{Cancelling}@2a1debfa, Dispatchers.Unconfined] Exception in thread "Test worker @coroutine#5" expected to be true at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:156) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:154) at com.uber.rib.core.WorkerBinderTestKt$Worker$1.onStart(WorkerBinderTest.kt:259) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:316) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:310) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$lambda-6$$inlined$collectWhile$1.emit(Limit.kt:143) at kotlinx.coroutines.flow.SharedFlowImpl.collect$suspendImpl(SharedFlow.kt:383) at kotlinx.coroutines.flow.SharedFlowImpl.collect(SharedFlow.kt) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:124) at kotlinx.coroutines.flow.FlowKt__EmittersKt$onCompletion$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:114) at com.uber.rib.core.WorkerBinderKt$bind$job$1.invokeSuspend(WorkerBinder.kt:310) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:367) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:30) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable$default(Cancellable.kt:25) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:110) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56) at kotlinx.coroutines.BuildersKt.launch(Unknown Source) at com.uber.rib.core.WorkerBinderKt.bind(WorkerBinder.kt:293) at com.uber.rib.core.WorkerBinderKt.access$bind(WorkerBinder.kt:1) at com.uber.rib.core.WorkerBinder.bind(WorkerBinder.kt:69) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invokeSuspend(WorkerBinderTest.kt:160) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invokeSuspend(TestBuilders.kt:212) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.intrinsics.UndispatchedKt.startCoroutineUndispatched(Undispatched.kt:55) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:112) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTestCoroutine(TestBuilders.kt:211) at kotlinx.coroutines.test.TestBuildersKt.runTestCoroutine(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invokeSuspend(TestBuilders.kt:167) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersJvmKt$createTestResult$1.invokeSuspend(TestBuildersJvm.kt:13) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284) at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59) at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38) at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source) at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:12) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:166) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:154) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest$default(TestBuilders.kt:147) at kotlinx.coroutines.test.TestBuildersKt.runTest$default(Unknown Source) at com.uber.rib.core.WorkerBinderTest.bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly(WorkerBinderTest.kt:151) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [CoroutineId(5), "coroutine#5":StandaloneCoroutine{Cancelling}@78b41097,
Updating to 1.7.3 and removing unneeded experimental API annotations
Changelog