Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coroutines 1.7.3 #609

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Update coroutines 1.7.3 #609

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0bf8a8
Update coroutines 1.7.3
tyvsmith Aug 22, 2023
09a08e6
Fixing test and removing ignore
tyvsmith Aug 22, 2023
24e3ae7
Fix spotless
tyvsmith Aug 22, 2023
25b8aaf
Setting worker dispatcher in test rule
tyvsmith Aug 22, 2023
a6e2109
addressing feedback
tyvsmith Aug 22, 2023
fa39761
Spotless
tyvsmith Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ compile-testing = "0.17"
compose-compiler = "1.4.6"
compose-libraries = "1.4.0"
compose-navigation = "2.4.0-alpha03"
coroutines = "1.6.4"
coroutines = "1.7.3"
dagger = "2.43.2"
errorprone = "2.3.3"
errorprone-javac = "9+181-r4173-1"
Expand All @@ -33,7 +33,7 @@ javapoet = "1.11.1"
jsr250 = "1.0"
junit = "4.12"
kotlin = "1.8.20"
kotlinx-coroutines = "1.6.4"
kotlinx-coroutines = "1.7.3"
ktfmt = "0.43"
ktlint = "0.48.2"
leakcanary = "1.5.4"
Expand Down
2 changes: 0 additions & 2 deletions android/libraries/rib-base/src/test/kotlin/com/uber/rib/core/LazyBackingPropertyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ package com.uber.rib.core

import com.google.common.truth.Truth.assertThat
import io.reactivex.Observable
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.channels.produce
import kotlinx.coroutines.channels.toList
import kotlinx.coroutines.launch
import kotlinx.coroutines.test.runTest
import org.junit.Test
import org.mockito.kotlin.mock

@OptIn(ExperimentalCoroutinesApi::class)
class LazyBackingPropertyTest {
@Volatile private var _expensiveObject: ExpensiveObject? = null
private val expensiveObject
Expand Down
4 changes: 1 addition & 3 deletions android/libraries/rib-base/src/test/kotlin/com/uber/rib/core/RibCoroutineWorkerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import kotlinx.coroutines.CoroutineExceptionHandler
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Delay
import kotlinx.coroutines.DelicateCoroutinesApi
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.InternalCoroutinesApi
import kotlinx.coroutines.Runnable
import kotlinx.coroutines.awaitCancellation
Expand All @@ -49,7 +48,6 @@ import org.junit.Test

private const val ON_START_DELAY_DURATION_MILLIS = 100L

@OptIn(ExperimentalCoroutinesApi::class)
class RibCoroutineWorkerTest {
@get:Rule val coroutineRule = RibCoroutinesRule()
private val worker = TestRibCoroutineWorker()
Expand Down Expand Up @@ -180,7 +178,7 @@ class RibCoroutineWorkerTest {
}
}

@OptIn(ExperimentalCoroutinesApi::class, InternalCoroutinesApi::class)
@OptIn(InternalCoroutinesApi::class)
private class ImmediateDispatcher(
scheduler: TestCoroutineScheduler,
private val delegate: TestDispatcher = StandardTestDispatcher(scheduler),
Expand Down
5 changes: 3 additions & 2 deletions android/libraries/rib-base/src/test/kotlin/com/uber/rib/core/WorkerBinderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class WorkerBinderTest(private val adaptFromRibCoroutineWorker: Boolean) {
@Before
fun setUp() {
RibEvents.enableRibActionEmissions()
RibCoroutinesConfig.deprecatedWorkerDispatcher = ribCoroutinesRule.ribDispatchers.Unconfined
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to handle previously failing test.

Exception in thread "Test worker @coroutine#2" expected to be true at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:156) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:154) at com.uber.rib.core.WorkerBinderTestKt$Worker$1.onStart(WorkerBinderTest.kt:259) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:316) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:310) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$lambda-6$$inlined$collectWhile$1.emit(Limit.kt:143) at kotlinx.coroutines.flow.SharedFlowImpl.collect$suspendImpl(SharedFlow.kt:383) at kotlinx.coroutines.flow.SharedFlowImpl.collect(SharedFlow.kt) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:124) at kotlinx.coroutines.flow.FlowKt__EmittersKt$onCompletion$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:114) at com.uber.rib.core.WorkerBinderKt$bind$job$1.invokeSuspend(WorkerBinder.kt:310) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:367) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:30) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable$default(Cancellable.kt:25) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:110) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56) at kotlinx.coroutines.BuildersKt.launch(Unknown Source) at com.uber.rib.core.WorkerBinderKt.bind(WorkerBinder.kt:293) at com.uber.rib.core.WorkerBinderKt.access$bind(WorkerBinder.kt:1) at com.uber.rib.core.WorkerBinder.bind(WorkerBinder.kt:69) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invokeSuspend(WorkerBinderTest.kt:160) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invokeSuspend(TestBuilders.kt:212) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.intrinsics.UndispatchedKt.startCoroutineUndispatched(Undispatched.kt:55) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:112) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTestCoroutine(TestBuilders.kt:211) at kotlinx.coroutines.test.TestBuildersKt.runTestCoroutine(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invokeSuspend(TestBuilders.kt:167) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersJvmKt$createTestResult$1.invokeSuspend(TestBuildersJvm.kt:13) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284) at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59) at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38) at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source) at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:12) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:166) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:154) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest$default(TestBuilders.kt:147) at kotlinx.coroutines.test.TestBuildersKt.runTest$default(Unknown Source) at com.uber.rib.core.WorkerBinderTest.bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly(WorkerBinderTest.kt:151) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [CoroutineId(2), "coroutine#2":StandaloneCoroutine{Cancelling}@2a1debfa, Dispatchers.Unconfined] Exception in thread "Test worker @coroutine#5" expected to be true at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:156) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1$worker$1.invoke(WorkerBinderTest.kt:154) at com.uber.rib.core.WorkerBinderTestKt$Worker$1.onStart(WorkerBinderTest.kt:259) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:316) at com.uber.rib.core.WorkerBinderKt$bind$job$1$3.emit(WorkerBinder.kt:310) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$lambda-6$$inlined$collectWhile$1.emit(Limit.kt:143) at kotlinx.coroutines.flow.SharedFlowImpl.collect$suspendImpl(SharedFlow.kt:383) at kotlinx.coroutines.flow.SharedFlowImpl.collect(SharedFlow.kt) at kotlinx.coroutines.flow.FlowKt__LimitKt$takeWhile$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:124) at kotlinx.coroutines.flow.FlowKt__EmittersKt$onCompletion$$inlined$unsafeFlow$1.collect(SafeCollector.common.kt:114) at com.uber.rib.core.WorkerBinderKt$bind$job$1.invokeSuspend(WorkerBinder.kt:310) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:367) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:30) at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable$default(Cancellable.kt:25) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:110) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56) at kotlinx.coroutines.BuildersKt.launch(Unknown Source) at com.uber.rib.core.WorkerBinderKt.bind(WorkerBinder.kt:293) at com.uber.rib.core.WorkerBinderKt.access$bind(WorkerBinder.kt:1) at com.uber.rib.core.WorkerBinder.bind(WorkerBinder.kt:69) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invokeSuspend(WorkerBinderTest.kt:160) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at com.uber.rib.core.WorkerBinderTest$bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly$1.invoke(WorkerBinderTest.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invokeSuspend(TestBuilders.kt:212) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$2.invoke(TestBuilders.kt) at kotlinx.coroutines.intrinsics.UndispatchedKt.startCoroutineUndispatched(Undispatched.kt:55) at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:112) at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTestCoroutine(TestBuilders.kt:211) at kotlinx.coroutines.test.TestBuildersKt.runTestCoroutine(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invokeSuspend(TestBuilders.kt:167) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$1$1.invoke(TestBuilders.kt) at kotlinx.coroutines.test.TestBuildersJvmKt$createTestResult$1.invokeSuspend(TestBuildersJvm.kt:13) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284) at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59) at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38) at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source) at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:12) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:166) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest(TestBuilders.kt:154) at kotlinx.coroutines.test.TestBuildersKt.runTest(Unknown Source) at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest$default(TestBuilders.kt:147) at kotlinx.coroutines.test.TestBuildersKt.runTest$default(Unknown Source) at com.uber.rib.core.WorkerBinderTest.bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly(WorkerBinderTest.kt:151) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [CoroutineId(5), "coroutine#5":StandaloneCoroutine{Cancelling}@78b41097,

}

@Test
Expand Down Expand Up @@ -138,7 +139,7 @@ class WorkerBinderTest(private val adaptFromRibCoroutineWorker: Boolean) {
}

@Test
fun bind_onStartIsCalledEagerly() {
fun bind_onStartIsCalledEagerly() = runTest {
val interactor = object : Interactor<Any, Router<*>>() {}
var onStartCalled = false
val worker = Worker { onStartCalled = true }
Expand All @@ -148,7 +149,7 @@ class WorkerBinderTest(private val adaptFromRibCoroutineWorker: Boolean) {
}

@Test
fun bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly() {
fun bind_whenSubscribeToLifecycleInWorker_observerIsCalledEagerly() = runTest {
val interactor = object : Interactor<Any, Router<*>>() {}
var enteredUnconfined = false
val worker = Worker {
Expand Down
2 changes: 0 additions & 2 deletions android/libraries/rib-coroutines-test/src/main/kotlin/com/uber/rib/core/RibCoroutinesRule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@
*/
package com.uber.rib.core

import kotlinx.coroutines.ExperimentalCoroutinesApi
import org.junit.rules.TestWatcher
import org.junit.runner.Description

/**
* RibCoroutinesRule is a Junit TestRule to act as a managed TestCoroutineScope in test and to
* facilitate install and cleanup of Test Dispatchers
*/
@ExperimentalCoroutinesApi
public class RibCoroutinesRule(
public val ribDispatchers: TestRibDispatchers = TestRibDispatchers(),
) : TestWatcher() {
Expand Down
7 changes: 0 additions & 7 deletions ...libraries/rib-coroutines-test/src/main/kotlin/com/uber/rib/core/TestRibCoroutineScopes.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,10 @@ import com.uber.autodispose.coroutinesinterop.autoDispose
import io.reactivex.Completable
import io.reactivex.CompletableSource
import kotlin.coroutines.CoroutineContext
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancel
import kotlinx.coroutines.test.TestScope

@ExperimentalCoroutinesApi
/** returns the [TestScope] override currently installed for testing. */
public val ScopeProvider.testScopeOverride: TestScope?
// Due to custom friend path usage, reference to LazyCoroutineScope will stay red in IDE
Expand All @@ -42,7 +40,6 @@ public val ScopeProvider.testScopeOverride: TestScope?
* Overrides [ScopeProvider.coroutineScope] with a [TestScope] with lifecycle integration for
* testing. Accessible directly as [TestScope] via [ScopeProvider.TestScopeOverride].
*/
@ExperimentalCoroutinesApi
public fun ScopeProvider.enableTestScopeOverride(
context: CoroutineContext = SupervisorJob(),
): Unit = synchronized(LazyCoroutineScope) { LazyCoroutineScope[this] = asTestScope(context) }
Expand All @@ -52,7 +49,6 @@ public fun ScopeProvider.disableTestScopeOverride(): Unit =
synchronized(LazyCoroutineScope) { LazyCoroutineScope[this] = null }

/** returns the [TestScope] override currently installed for testing. */
@ExperimentalCoroutinesApi
public val Application.testScopeOverride: TestScope?
// Due to custom friend path usage, reference to LazyCoroutineScope will stay red in IDE
get() =
Expand All @@ -65,7 +61,6 @@ public val Application.testScopeOverride: TestScope?
* Overrides [ScopeProvider.coroutineScope] with a [TestScope] with lifecycle integration for
* testing. Accessible directly as [TestScope] via [ScopeProvider.TestScopeOverride].
*/
@ExperimentalCoroutinesApi
public fun Application.enableTestScopeOverride(context: CoroutineContext = SupervisorJob()): Unit =
synchronized(LazyCoroutineScope) { LazyCoroutineScope[this] = TestScope(context) }

Expand All @@ -74,13 +69,11 @@ public fun Application.disableTestScopeOverride(): Unit =
synchronized(LazyCoroutineScope) { LazyCoroutineScope[this] = null }

/** Returns a new [TestScope] from the [ScopeProvider] */
@ExperimentalCoroutinesApi
public fun ScopeProvider.asTestScope(context: CoroutineContext = SupervisorJob()): TestScope {
return requestScope().asTestScope(context)
}

/** Returns a new [TestScope] from the [CompletableSource] */
@ExperimentalCoroutinesApi
public fun CompletableSource.asTestScope(context: CoroutineContext = SupervisorJob()): TestScope {
val scope = TestScope(context)
Completable.wrap(this).autoDispose(scope).subscribe({ scope.cancel() }) { e ->
Expand Down
2 changes: 0 additions & 2 deletions ...oid/libraries/rib-coroutines-test/src/main/kotlin/com/uber/rib/core/TestRibDispatchers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package com.uber.rib.core

import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.MainCoroutineDispatcher
import kotlinx.coroutines.test.StandardTestDispatcher
import kotlinx.coroutines.test.TestCoroutineScheduler
Expand All @@ -25,7 +24,6 @@ import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.resetMain
import kotlinx.coroutines.test.setMain

@ExperimentalCoroutinesApi
public data class TestRibDispatchers(
/**
* [TestCoroutineScheduler] to be used by all other [TestDispatcher] when using the default
Expand Down
2 changes: 0 additions & 2 deletions .../libraries/rib-coroutines-test/src/test/kotlin/com/uber/rib/core/RibCoroutinesRuleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package com.uber.rib.core

import com.google.common.truth.Truth.assertThat
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.delay
import kotlinx.coroutines.launch
import kotlinx.coroutines.test.advanceTimeBy
Expand All @@ -25,7 +24,6 @@ import kotlinx.coroutines.test.runTest
import org.junit.Rule
import org.junit.Test

@OptIn(ExperimentalCoroutinesApi::class)
class RibCoroutinesRuleTest {
@get:Rule val ribCoroutinesRule = RibCoroutinesRule()

Expand Down
2 changes: 0 additions & 2 deletions ...oid/libraries/rib-coroutines-test/src/test/kotlin/com/uber/rib/core/RibDispatchersTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ package com.uber.rib.core

import com.google.common.truth.Truth.assertThat
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.TestCoroutineDispatcher
import org.junit.Test

@OptIn(ExperimentalCoroutinesApi::class)
internal class RibDispatchersTest {

@Test
Expand Down
2 changes: 0 additions & 2 deletions android/libraries/rib-coroutines-test/src/test/kotlin/com/uber/rib/core/RibScopesTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import android.app.Application
import com.google.common.truth.Truth.assertThat
import kotlin.coroutines.CoroutineContext
import kotlinx.coroutines.CoroutineExceptionHandler
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.delay
import kotlinx.coroutines.isActive
import kotlinx.coroutines.launch
Expand All @@ -29,7 +28,6 @@ import org.junit.Rule
import org.junit.Test
import org.mockito.kotlin.mock

@OptIn(ExperimentalCoroutinesApi::class)
internal class RibScopesTest {

@get:Rule var rule = RibCoroutinesRule()
Expand Down