Add new CI step for lint validation (#4903)

* fix lint error

* add new CI step for lint

* commit change after lint

* add missing dependency of makefile rule

* address comments: remove excessive artifact paths

.buildkite/pipeline-master.yml

@@ -19,6 +19,20 @@ steps:
           run: unit-test
           config: docker/buildkite/docker-compose.yml
 
+  - label: ":golangci-lint: validate code is clean"
+    agents:
+      queue: "workers"
+      docker: "*"
+    command: "./scripts/buildkite/golint.sh"
+    artifact_paths: []
+    retry:
+      automatic:
+        limit: 1
+    plugins:
+      - docker-compose#v3.0.0:
+          run: unit-test
+          config: docker/buildkite/docker-compose.yml
+
   - label: ":golang: integration test with cassandra"
     agents:
       queue: "workers"

.buildkite/pipeline-pull-request.yml

@@ -19,6 +19,20 @@ steps:
           run: unit-test
           config: docker/buildkite/docker-compose.yml
 
+  - label: ":golangci-lint: validate code is clean"
+    agents:
+      queue: "workers"
+      docker: "*"
+    command: "./scripts/buildkite/golint.sh"
+    artifact_paths: []
+    retry:
+      automatic:
+        limit: 1
+    plugins:
+      - docker-compose#v3.0.0:
+          run: unit-test
+          config: docker/buildkite/docker-compose.yml
+
   - label: ":golang: integration test with cassandra"
     agents:
       queue: "workers"

Makefile

@@ -387,7 +387,7 @@ lint: ## (re)run the linter
 fmt: $(BUILD)/fmt ## run goimports
 
 # not identical to the intermediate target, but does provide the same codegen (or more).
-copyright: $(BIN)/copyright ## update copyright headers
+copyright: $(BIN)/copyright | $(BUILD) ## update copyright headers
 	$(BIN)/copyright
 	$Q touch $(BUILD)/copyright
 

proto/buf.yaml

@@ -6,5 +6,9 @@ build:
 lint: # Uber style rules: https://docs.buf.build/migration-prototool/#uber1-uber2
   use:
     - DEFAULT
+  ignore_only:
+    FIELD_LOWER_SNAKE_CASE:
+      - uber/cadence/history/v1/service.proto
+      - uber/cadence/matching/v1/service.proto
   enum_zero_value_suffix: _INVALID
   service_suffix: API

scripts/buildkite/golint.sh

@@ -0,0 +1,12 @@
+#!/bin/sh
+
+set -ex
+
+make go-generate && make fmt && make lint && make copyright
+
+if [ -n "$(git status --porcelain)" ]; then
+  echo "There are changes after make go-generate && make fmt && make lint && make copyright"
+  echo "Please rerun the command and commit the changes"
+  git status --porcelain
+  exit 1
+fi